Schedule user logged in (#470)

* refactoring handler darwin

* refactoring string permission into an enum
move detectSchedulePermission to the handler
which broke many tests using the mock handler

* fix tests

* trying to use bootstrap commands

* investigations

* fix permissions

* fix launchctl system job

* parse launchctl print

* print schedule status

* remove agent before re-creating

* update documentation with new features on launchd

* check permission on cron scheduler

* add user permission on test profile

* move permission check to handler (as crond is different than systemd)

* add tests on DetectSchedulePermission

* docs: inform we can set the cron user manually in config

* detect user after sudo

* fix getting username on windows

* use root user on system jobs

* docs: explain how systemd services are generated

* generate systemd service with User field

* don't display epoch when there's no next run

* fix wording

* detect systemd service type (system or user)

* systemd unit type system for background user

* add a few new tests

* simplify String method

* add user parameter to CheckPermission

* remove support for crond on windows

* fix tests references to crond for windows

* avoid checking links not already available :facepalm

* nitpick comments

* add a few more tests

Author: creativeprojects

.github/workflows/doc.yml

@@ -55,7 +55,7 @@ jobs:
         with:
           url: "https://${{ env.BRANCH_NAME }}.resticprofile.pages.dev/"
           pages_path: ./public/
-          cmd_params: '--exclude="(linux.die.net|stackoverflow.com|scoop.sh)" --buffer-size=8192 --max-connections=10 --color=always --skip-tls-verification --header="User-Agent:curl/7.54.0" --timeout=20'
+          cmd_params: '--exclude="(linux\.die\.net|stackoverflow\.com|scoop\.sh|0-18)" --buffer-size=8192 --max-connections=10 --color=always --skip-tls-verification --header="User-Agent:curl/7.54.0" --timeout=20'
 
       - name: Publish to pages.dev
         continue-on-error: true # secrets are not set for PRs from forks

.github/workflows/release-doc.yml

@@ -49,7 +49,7 @@ jobs:
         with:
           url: https://creativeprojects.github.io/resticprofile/
           pages_path: ./www/
-          cmd_params: '--exclude="(linux.die.net|stackoverflow.com|scoop.sh)" --buffer-size=8192 --max-connections-per-host=5 --rate-limit=5 --timeout=20 --header="User-Agent:curl/7.54.0" --skip-tls-verification'
+          cmd_params: '--exclude="(linux\.die\.net|stackoverflow\.com|scoop\.sh|0-18)" --buffer-size=8192 --max-connections-per-host=5 --rate-limit=5 --timeout=20 --header="User-Agent:curl/7.54.0" --skip-tls-verification'
 
       - name: Deploy to GitHub Pages
         uses: peaceiris/actions-gh-pages@v4

.gitignore

@@ -3,9 +3,11 @@
 
 .DS_Store
 /examples/private
+/examples/*-log.txt
 /build/restic*
 /build/rclone*
 /dist
+/crontab
 
 # binary
 /resticprofile*

Makefile

@@ -194,7 +194,7 @@ ${TMP_MOUNT_DARWIN}:
 # Mount tmpfs on linux
 ${TMP_MOUNT_LINUX}:
 	mkdir -p ${TMP_MOUNT_LINUX}
-	sudo mount -t tmpfs -o "rw,relatime,size=2097152k" tmpfs ${TMP_MOUNT_LINUX}
+	sudo mount -t tmpfs -o "rw,relatime,size=2097152k,uid=`id -u`,gid=`id -g`" tmpfs ${TMP_MOUNT_LINUX}
 
 rest-server:
 	@echo "[*] $@"
@@ -298,7 +298,7 @@ checkdoc:
 .PHONY: checklinks
 checklinks:
 	@echo "[*] $@"
-	muffet -b 8192 --max-connections=10 --exclude="(linux.die.net|stackoverflow.com|scoop.sh)" http://localhost:1313/resticprofile/
+	muffet -b 8192 --max-connections=10 --exclude="(linux\.die\.net|stackoverflow\.com|scoop\.sh|0-18)" http://localhost:1313/resticprofile/
 
 .PHONY: lint
 lint: $(GOBIN)/golangci-lint

codecov.yml

@@ -12,6 +12,7 @@ ignore:
   - syslog.go
   - syslog_windows.go
   - schtasks/permission.go
+  - user/user_systemd.go
   - "**/mocks/*.go"
 
 codecov:

commands_schedule_test.go

@@ -1,3 +1,5 @@
+//go:build !windows
+
 package main
 
 import (
@@ -40,11 +42,13 @@ profiles:
   profile-schedule-inline:
     backup:
       schedule: "*:00,30"
+      schedule-permission: "user"
 
   profile-schedule-struct:
     backup:
       schedule:
         at: "*:20,50"
+        permission: "user"
 
 `
 

constants/value.go

@@ -2,12 +2,14 @@ package constants
 
 // Parameter values
 const (
+	SchedulePermissionAuto         = "auto"
+	SchedulePermissionSystem       = "system"
 	SchedulePermissionUser         = "user"
 	SchedulePermissionUserLoggedOn = "user_logged_on"
 	SchedulePermissionUserLoggedIn = "user_logged_in"
-	SchedulePermissionSystem       = "system"
-	SchedulePriorityBackground     = "background"
-	SchedulePriorityStandard       = "standard"
+
+	SchedulePriorityBackground = "background"
+	SchedulePriorityStandard   = "standard"
 
 	VerbosityNone   = 0
 	VerbosityLevel1 = 1

crond/crontab.go

@@ -1,13 +1,15 @@
+//go:build !windows
+
 package crond
 
 import (
 	"errors"
 	"fmt"
 	"io"
-	"os/user"
 	"regexp"
 	"strings"
 
+	"github.com/creativeprojects/resticprofile/user"
 	"github.com/spf13/afero"
 )
 
@@ -172,9 +174,9 @@ func (c *Crontab) LoadCurrent() (content string, err error) {
 
 func (c *Crontab) username() string {
 	if len(c.user) == 0 {
-		if current, err := user.Current(); err == nil {
-			c.user = current.Username
-		}
+		current := user.Current()
+		c.user = current.Username
+
 		if len(c.user) == 0 || strings.ContainsAny(c.user, "\t \n\r") {
 			c.user = "root"
 		}

crond/crontab_test.go

@@ -1,3 +1,5 @@
+//go:build !windows
+
 package crond
 
 import (

crond/entry.go

@@ -1,3 +1,5 @@
+//go:build !windows
+
 package crond
 
 import (