Skip to content

fix(schedule): allow task scheduling when on battery power#609

Merged
creativeprojects merged 1 commit intomasterfrom
run-task-scheduler-on-battery
Mar 26, 2026
Merged

fix(schedule): allow task scheduling when on battery power#609
creativeprojects merged 1 commit intomasterfrom
run-task-scheduler-on-battery

Conversation

@creativeprojects
Copy link
Copy Markdown
Owner

Fixes #595

Copilot AI review requested due to automatic review settings March 26, 2026 22:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the default Windows Task Scheduler task definition so scheduled jobs can start while running on battery power (addressing #595’s “Start the task only if the computer is on AC power” option being effectively enabled by default).

Changes:

  • Set the default TaskSettings.DisallowStartIfOnBatteries value to false in the Windows scheduled task template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread schtasks/task.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (b4984af) to head (f19f1ed).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files         137      137           
  Lines       11092    11092           
=======================================
  Hits         8989     8989           
  Misses       1677     1677           
  Partials      426      426           
Flag Coverage Δ
unittests 81.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creativeprojects creativeprojects merged commit dd15110 into master Mar 26, 2026
11 checks passed
@creativeprojects creativeprojects deleted the run-task-scheduler-on-battery branch March 26, 2026 22:09
@creativeprojects creativeprojects added this to the v0.33.0 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: schedule-ignore-on-battery does not properly set Windows Task Scheduler value

2 participants