Skip to content

chore: upgrade to go 1.26#610

Merged
creativeprojects merged 7 commits intomasterfrom
go-1.26
Mar 26, 2026
Merged

chore: upgrade to go 1.26#610
creativeprojects merged 7 commits intomasterfrom
go-1.26

Conversation

@creativeprojects
Copy link
Copy Markdown
Owner

@creativeprojects creativeprojects commented Mar 26, 2026

chore: upgrade to Go 1.26

Upgrades the Go toolchain from 1.25.8 to 1.26.1 and updates the build toolchain accordingly.

Toolchain changes:

  • Bumped go.mod to go 1.26.1
  • Updated golangci-lint from v2.5.0 to v2.9.0 (binary renamed to golangci-lint-v2)
  • Updated mockery from v3.5.5 to v3.7.0
  • Pinned GoReleaser to ~> v2 instead of latest in CI workflows
  • Fixed GOCMD to use command -v go and corrected the GOPATH check in the Makefile

Lint fixes (prompted by updated linter rules):

  • Pre-allocated slices with known or estimated capacities across several files
  • Fixed a loop index bug in task.go (convertDaysOfMonth) and added test coverage for it
  • Fixed error comparison in duration_test.go to use .Error() string comparison

Copilot AI review requested due to automatic review settings March 26, 2026 22:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (dd15110) to head (1478419).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files         137      137           
  Lines       11092    11092           
=======================================
  Hits         8989     8989           
  Misses       1677     1677           
  Partials      426      426           
Flag Coverage Δ
unittests 81.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

schedule/handler_darwin.go:180

  • This preallocates jobs with a hard-coded capacity of 10. Since the final size depends on systemJobs and userJobs, either avoid the magic number (let append grow), or compute capacity after fetching both slices (len(systemJobs)+len(userJobs)) to keep the allocation aligned with actual data.
func (h *HandlerLaunchd) Scheduled(profileName string) ([]Config, error) {
	jobs := make([]Config, 0, 10)
	if profileName == "" {
		profileName = "*"
	} else {
		profileName = strings.ToLower(profileName)
	}
	// system jobs
	systemJobs := h.getScheduledJob(profileName, constants.SchedulePermissionSystem)
	jobs = append(jobs, systemJobs...)
	// user jobs
	userJobs := h.getScheduledJob(profileName, constants.SchedulePermissionUser)
	jobs = append(jobs, userJobs...)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread util/maybe/duration_test.go
Comment thread wrapper.go Outdated
Comment thread Makefile
@creativeprojects creativeprojects merged commit cc27dd2 into master Mar 26, 2026
5 checks passed
@creativeprojects creativeprojects deleted the go-1.26 branch March 26, 2026 23:22
@creativeprojects creativeprojects added this to the v0.33.0 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants