Skip to content

update dependencies to use gopsutil v4#629

Merged
creativeprojects merged 1 commit into
masterfrom
fix-crash-on-apple-m5
Apr 15, 2026
Merged

update dependencies to use gopsutil v4#629
creativeprojects merged 1 commit into
masterfrom
fix-crash-on-apple-m5

Conversation

@creativeprojects

Copy link
Copy Markdown
Owner

update dependencies to use gopsutil from v3 to v4

gopsutil v4 version no longer needs go-m1cpu package

Fixes #628

Copilot AI review requested due to automatic review settings April 15, 2026 14:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s process-inspection dependency to gopsutil v4 to eliminate the go-m1cpu transitive dependency implicated in macOS (M5) crashes (issue #628), and refreshes related module versions.

Changes:

  • Migrate gopsutil imports from github.com/shirou/gopsutil/v3/... to .../v4/... in the lock implementation and tests.
  • Update go.mod/go.sum to require github.com/shirou/gopsutil/v4 and drop github.com/shoenig/go-m1cpu (plus related dependency updates).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
lock/lock.go Switches process PID existence checks to gopsutil v4 import path.
lock/lock_test.go Updates tests to use gopsutil v4 process APIs.
go.mod Bumps gopsutil to v4, removes go-m1cpu indirect dep, and updates related module versions.
go.sum Reflects the updated dependency graph (adds v4-related sums; removes v3/go-m1cpu sums).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.55%. Comparing base (9653541) to head (49102a5).
⚠️ Report is 12 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   80.41%   79.55%   -0.86%     
==========================================
  Files         150      170      +20     
  Lines       11796    12300     +504     
==========================================
+ Hits         9485     9785     +300     
- Misses       1827     2020     +193     
- Partials      484      495      +11     
Flag Coverage Δ
unittests 77.85% <ø> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creativeprojects creativeprojects merged commit a0406f0 into master Apr 15, 2026
14 checks passed
@creativeprojects creativeprojects deleted the fix-crash-on-apple-m5 branch June 27, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

segmentation fault on new mac m5 chips due to go-m1cpu

2 participants