Skip to content

add description to zsh completion#656

Merged
creativeprojects merged 1 commit into
masterfrom
zsh-completion-description
Jun 28, 2026
Merged

add description to zsh completion#656
creativeprojects merged 1 commit into
masterfrom
zsh-completion-description

Conversation

@creativeprojects

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 27, 2026 17:49
@creativeprojects creativeprojects self-assigned this Jun 27, 2026
@creativeprojects creativeprojects added the enhancement New feature or request label Jun 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends resticprofile complete to optionally include tab-separated descriptions for zsh (via a new zsh:v2 protocol version) and updates the bundled zsh completion script to display those descriptions in completion listings.

Changes:

  • Add zsh:v2 support to include descriptions in completion output (gated by requester version).
  • Update the zsh completion script to request zsh:v2 and attempt to show descriptions.
  • Extend completion tests to cover zsh:v2 returning descriptions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
contrib/completion/zsh-completion.zsh Adds a helper to render tab-separated descriptions and switches the protocol to zsh:v2.
commands.go Enables descriptions for zsh:v2 (and keeps zsh:v1 behavior unchanged).
commands_test.go Adds a test case asserting zsh:v2 includes descriptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread contrib/completion/zsh-completion.zsh
@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.96%. Comparing base (b3a589e) to head (05c65ba).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #656   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files         162      162           
  Lines       12122    12122           
=======================================
  Hits         9814     9814           
  Misses       1810     1810           
  Partials      498      498           
Flag Coverage Δ
unittests 79.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@creativeprojects creativeprojects merged commit 3aa1885 into master Jun 28, 2026
14 checks passed
@creativeprojects creativeprojects deleted the zsh-completion-description branch June 28, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants