[Feature Request] Use router-link instead of a href for some links in the footer#6
Open
kinow wants to merge 1 commit into
Open
[Feature Request] Use router-link instead of a href for some links in the footer#6kinow wants to merge 1 commit into
kinow wants to merge 1 commit into
Conversation
johnleider
suggested changes
Nov 1, 2019
johnleider
left a comment
johnleider
left a comment
Contributor
There was a problem hiding this comment.
This can be cleaned up a bit. Ensure that the code style matches that of the project, it should auto-fix errors. Instead of having a new param, we can assume if the link starts with http, it's not a router link.
johnleider
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added a couple of links to routes like
/aboutand/dashboardin my footer, and noticed it was refreshing the page. Then realized it wasn't usingrouter-link.Not super experienced with Vue.js yet, but tried my best at using an
ifand rendering the<a>or a<router-link>based on a property of the data entry.Cheers
Bruno