fix: install script#1599
Conversation
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughEnvironment configuration updates across two files: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
agent.env (1)
184-188: Please track the install-script TODO as a concrete follow-up.Line 184 leaves endpoint variable sync manual; this can drift over time. Either wire it now or create a follow-up issue tied to this PR.
If you want, I can draft the follow-up issue text/checklist for automating these endpoint updates.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@agent.env` around lines 184 - 188, The TODO about keeping endpoint env vars in sync must be actioned: either update the install script to programmatically set APP_URL, AGENT_HTTP_URL and TRUST_LIST_URL in agent.env whenever endpoints change (e.g., add logic in the installer to replace those keys or template the file from variables), or create a concrete follow-up issue and link it to this PR describing the exact tasks (write installer update step, add tests/CI check to validate parity, and document the variables). Locate the references to APP_URL, AGENT_HTTP_URL and TRUST_LIST_URL in the agent.env diff and implement the installer wiring or open the follow-up issue accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@agent.env`:
- Around line 184-188: The TODO about keeping endpoint env vars in sync must be
actioned: either update the install script to programmatically set APP_URL,
AGENT_HTTP_URL and TRUST_LIST_URL in agent.env whenever endpoints change (e.g.,
add logic in the installer to replace those keys or template the file from
variables), or create a concrete follow-up issue and link it to this PR
describing the exact tasks (write installer update step, add tests/CI check to
validate parity, and document the variables). Locate the references to APP_URL,
AGENT_HTTP_URL and TRUST_LIST_URL in the agent.env diff and implement the
installer wiring or open the follow-up issue accordingly.
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
|



What:
Summary by CodeRabbit