Skip to content

fix: install script#1599

Merged
GHkrishna merged 3 commits into
mainfrom
fix/install-script
Apr 13, 2026
Merged

fix: install script#1599
GHkrishna merged 3 commits into
mainfrom
fix/install-script

Conversation

@GHkrishna
Copy link
Copy Markdown
Contributor

@GHkrishna GHkrishna commented Apr 13, 2026

What:

  • Add missing env variables

Summary by CodeRabbit

  • Chores
    • Updated local development environment configuration defaults for NATS authentication mode.
    • Added new agent HTTP configuration parameters including localhost URL settings and request body size limits.
    • Updated logging configuration format for development setup.

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 13, 2026

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • agent.env
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f2cf569-7daf-44b2-ae69-11f6857bddf0

📥 Commits

Reviewing files that changed from the base of the PR and between d496faf and afddf2b.

📒 Files selected for processing (1)
  • agent.env

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Environment configuration updates across two files: .env.demo adjusts Prisma logging format and changes NATS authentication mode from nkey to none for local development; agent.env adds new development environment variables for Node environment, request body size limits, and application URLs.

Changes

Cohort / File(s) Summary
Environment Configuration
.env.demo
Removed whitespace from PRISMA_LOGS variable format and changed NATS authentication type from nkey to none with explanatory comment for local setup.
Agent Environment Variables
agent.env
Added development-focused environment variables including NODE_ENV=DEV, request body size limits (APP_JSON_BODY_SIZE, APP_URL_ENCODED_BODY_SIZE), HTTP configuration flag, and application URLs for local development setup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • refactor: .env.demo file #1595: Modifies .env.demo file with NATS-related environment variable defaults, suggesting alignment with broader environment configuration updates.

Suggested reviewers

  • ankita-p17
  • shitrerohit

Poem

🐰 Configuration hops with care,
Environment variables laid fair,
NATS says "none" for dev's delight,
Body sizes set just right,
Local URLs shine so bright! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: install script' is vague and generic. While the PR does update environment configuration files, the title doesn't clearly convey that the changes involve adding and modifying environment variables. Consider a more descriptive title that reflects the actual changes, such as 'fix: add missing environment variables to .env.demo and agent.env' or 'fix: configure environment variables for local setup'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/install-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
agent.env (1)

184-188: Please track the install-script TODO as a concrete follow-up.

Line 184 leaves endpoint variable sync manual; this can drift over time. Either wire it now or create a follow-up issue tied to this PR.

If you want, I can draft the follow-up issue text/checklist for automating these endpoint updates.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@agent.env` around lines 184 - 188, The TODO about keeping endpoint env vars
in sync must be actioned: either update the install script to programmatically
set APP_URL, AGENT_HTTP_URL and TRUST_LIST_URL in agent.env whenever endpoints
change (e.g., add logic in the installer to replace those keys or template the
file from variables), or create a concrete follow-up issue and link it to this
PR describing the exact tasks (write installer update step, add tests/CI check
to validate parity, and document the variables). Locate the references to
APP_URL, AGENT_HTTP_URL and TRUST_LIST_URL in the agent.env diff and implement
the installer wiring or open the follow-up issue accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@agent.env`:
- Around line 184-188: The TODO about keeping endpoint env vars in sync must be
actioned: either update the install script to programmatically set APP_URL,
AGENT_HTTP_URL and TRUST_LIST_URL in agent.env whenever endpoints change (e.g.,
add logic in the installer to replace those keys or template the file from
variables), or create a concrete follow-up issue and link it to this PR
describing the exact tasks (write installer update step, add tests/CI check to
validate parity, and document the variables). Locate the references to APP_URL,
AGENT_HTTP_URL and TRUST_LIST_URL in the agent.env diff and implement the
installer wiring or open the follow-up issue accordingly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d0934748-53f6-475b-aa35-8fcc7ae331cc

📥 Commits

Reviewing files that changed from the base of the PR and between ff37552 and d496faf.

📒 Files selected for processing (2)
  • .env.demo
  • agent.env

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@sonarqubecloud
Copy link
Copy Markdown

@GHkrishna GHkrishna self-assigned this Apr 13, 2026
@GHkrishna GHkrishna added the bug Something isn't working label Apr 13, 2026
@GHkrishna GHkrishna requested a review from KambleSahil3 April 13, 2026 10:16
Copy link
Copy Markdown
Contributor

@KambleSahil3 KambleSahil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GHkrishna GHkrishna merged commit 6d37578 into main Apr 13, 2026
8 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 14, 2026
@GHkrishna GHkrishna deleted the fix/install-script branch April 20, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants