From 0cf770312e2726a8c704affc1f3ce5897e6bb4eb Mon Sep 17 00:00:00 2001 From: Miles Date: Sat, 4 Apr 2026 08:40:59 -0400 Subject: [PATCH] fix: rename loop variable to avoid shadowing provider parameter In create_crew(), the for loop `for provider, env_keys in ENV_VARS.items()` reused the name `provider`, clobbering the function parameter after the loop. While the parameter is not currently referenced post-loop, the shadowing is a latent bug that would silently break any future use of the original value. Renamed to `env_provider` to keep the parameter intact. --- lib/crewai/src/crewai/cli/create_crew.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/crewai/src/crewai/cli/create_crew.py b/lib/crewai/src/crewai/cli/create_crew.py index 9bca7c4993..6b1327599d 100644 --- a/lib/crewai/src/crewai/cli/create_crew.py +++ b/lib/crewai/src/crewai/cli/create_crew.py @@ -211,12 +211,12 @@ def create_crew( return existing_provider = None - for provider, env_keys in ENV_VARS.items(): + for env_provider, env_keys in ENV_VARS.items(): if any( "key_name" in details and details["key_name"] in env_vars for details in env_keys ): - existing_provider = provider + existing_provider = env_provider break if existing_provider: