fix: rename loop variable that shadows provider parameter in create_crew()#5401
Closed
Dheeraj-Bhaskaruni wants to merge 2 commits intocrewAIInc:mainfrom
Closed
fix: rename loop variable that shadows provider parameter in create_crew()#5401Dheeraj-Bhaskaruni wants to merge 2 commits intocrewAIInc:mainfrom
Dheeraj-Bhaskaruni wants to merge 2 commits intocrewAIInc:mainfrom
Conversation
…_crew() The `for provider, env_keys in ENV_VARS.items()` loop on line 214 shadows the `provider` function parameter. After the loop, `provider` no longer holds the caller's original value. Renamed the loop variable to `env_provider` to prevent this. Fixes crewAIInc#5270
Contributor
|
Duplicate of #5272. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5270
The
for provider, env_keys in ENV_VARS.items()loop increate_crew()shadows theproviderfunction parameter. After the loop completes,providerholds the last key fromENV_VARSinstead of the caller's original value.Renamed the loop variable to
env_providerto prevent the shadowing.File changed
lib/crewai/src/crewai/cli/create_crew.pyTest plan
crewai create crew test --provider openaistill works correctly