v2.1.0 add support for tags editing#167
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds end-to-end UI/model support for editing Key Vault secret tags (add/edit/remove) and bumps the app version to 2.1.0, including UI layout tweaks and localization updates.
Changes:
- Introduces a
TagsEditoruser control and wires it into the “New Item” and “New Version/Edit” flows. - Adds
EditableTags/TagItemto the model layer and updates tag rendering to useItemsRepeater+ wrap layout. - Updates package/app versions and adds new localized strings for the tag editor UI.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/uno/global.json | Updates Uno SDK version used by the repo. |
| src/uno/AzureKeyVaultStudio/Directory.Packages.props | Bumps Azure.ResourceManager.KeyVault package version. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/NewVersionViewModel.cs | Uses editable tags during secret version creation; adds error handling on update. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/TagsEditor.xaml.cs | New tags editor code-behind and DP surface. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/TagsEditor.xaml | New tags editor UI using ItemsRepeater and localized UIDs. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/NewVersionDialog.xaml | Hosts TagsEditor in the dialog and adjusts min width. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/NewItem.xaml.cs | Adjusts dialog button text/localization behavior. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/NewItem.xaml | Hosts TagsEditor in the new-item UI. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ItemDetails.xaml | Updates tag rendering in details view; adds keyboard accelerators. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Strings/*/Resources.resw | Adds localization entries for tags editor UI and close button text. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/VaultTabContentPage.xaml | Updates tag “chip” styling to improve highlight visibility. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Package.appxmanifest | Bumps package version to 2.1.0.0. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Models/KeyVaultValuesAmalgamation.cs | Adds EditableTags and applies editable tags when producing SDK property objects. |
| src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/AzureKeyVaultStudio.csproj | Bumps display version and removes explicit content copy entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cricketthomas
force-pushed
the
feature/100-tags
branch
from
23ee60c to
96d433c
Compare
cricketthomas
force-pushed
the
feature/100-tags
branch
from
96d433c to
57c5be9
Compare
…icates, and remove unused code
cricketthomas
force-pushed
the
feature/100-tags
branch
from
57c5be9 to
5a9ba50
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- reuse existing code for tags - don't show close and dismiss button on new item page - fix split view width over emitting to events - increase height for secret
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tag editing support
Closes #100