Fix: Azure portal baseUri for gov, china and germany#168
Merged
Conversation
Owner
cricketthomas
commented
Mar 31, 2026
cricketthomas
commented
- add new switch for portal base uri/tld
- update respective code to use new tlds var
…sources to "portal.com" rather than their correct azure base uri/tld
There was a problem hiding this comment.
Pull request overview
This PR updates “Open in Azure” links to use the correct Azure Portal base URI for non-public Azure clouds (US Gov, China, Germany) by deriving the portal hostname from the selected AzureCloudInstance.
Changes:
- Introduced
AuthService.AzurePortalBaseUriand set it via aCloudInstanceswitch (public, gov, china, germany). - Updated multiple view models to build Azure Portal deep-links using
AzurePortalBaseUriinstead of a hardcodedhttps://portal.azure.com.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Services/AuthService.cs |
Adds AzurePortalBaseUri and maps it from CloudInstance. |
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/KeyVaultTreeViewModel.cs |
Uses AzurePortalBaseUri when opening resources in the portal. |
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/UserControls/ViewModels/ItemPropertiesViewModel.cs |
Uses AzurePortalBaseUri for Key Vault asset deep-links. |
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/ViewModels/VaultViewModel.cs |
Uses AzurePortalBaseUri for Key Vault asset deep-links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cricketthomas
added a commit
that referenced
this pull request
Mar 31, 2026
* Fix: previously it would send all azure China, Germany, and us gov resources to "portal.com" rather than their correct azure base Uri/tld * Address copilot warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.