update window size for tags#169
Merged
Merged
Conversation
bump vulnerable package
There was a problem hiding this comment.
Pull request overview
Updates the sizing behavior of secondary windows (e.g., item properties / new secret) to be DPI-aware so tag-related UI has adequate space, while also addressing a vulnerable dependency by pinning/updating packages.
Changes:
- Bump
Uno.Sdkversion insrc/uno/global.json. - Add/pin
Tmds.DBus.Protocolvia central package management and reference it in the app project. - Replace direct
AppWindow.Resize(...)calls with a DPI-scaled resize helper for better cross-DPI window sizing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/uno/global.json |
Updates Uno SDK version used by the solution. |
src/uno/AzureKeyVaultStudio/Directory.Packages.props |
Pins Tmds.DBus.Protocol to a specific version for dependency/vulnerability control. |
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/AzureKeyVaultStudio.csproj |
Adds the package reference to ensure the pinned dependency is used. |
src/uno/AzureKeyVaultStudio/AzureKeyVaultStudio/Presentation/ViewModels/VaultViewModel.cs |
Introduces DPI-scaled window resizing and updates window sizes for tag-related UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.