Add alias management features: create, delete, and view aliases with detailed info

dmcrider · dmcrider · commit 2d8fa045e575 · 2025-08-06T10:03:46.000-07:00
diff --git a/src-tauri/src/main.rs b/src-tauri/src/main.rs
@@ -37,6 +37,13 @@ struct ValidationResponse {
     exists: bool,
 }
 
+#[derive(Debug, Serialize, Deserialize)]
+struct AliasInfo {
+    name: String,
+    command: String,
+    created_by_tool: bool,
+}
+
 #[derive(Debug, Serialize, Deserialize)]
 struct OpenAIRequest {
     model: String,
@@ -244,6 +251,21 @@ async fn create_alias(request: AliasRequest) -> AliasResponse {
     match output {
         Ok(result) => {
             if result.status.success() {
+                // Mark this alias as created by our tool
+                let marker_result = Command::new("git")
+                    .args(&[
+                        "config",
+                        "--global",
+                        &format!("alias-tool.{}", request.alias_name),
+                        "git-alias-generator",
+                    ])
+                    .output();
+                
+                if let Err(_) = marker_result {
+                    // If we can't mark it, that's not critical
+                    eprintln!("Warning: Could not mark alias as created by tool");
+                }
+
                 AliasResponse {
                     success: true,
                     message: format!("Alias '{}' created successfully!", request.alias_name),
@@ -293,6 +315,74 @@ async fn get_existing_aliases() -> Result<Vec<String>, String> {
     Ok(aliases)
 }
 
+#[tauri::command]
+async fn get_detailed_aliases() -> Result<Vec<AliasInfo>, String> {
+    let output = Command::new("git")
+        .args(&["config", "--global", "--get-regexp", "^alias\\."])
+        .output()
+        .map_err(|e| format!("Failed to get aliases: {}", e))?;
+
+    let aliases_text = String::from_utf8_lossy(&output.stdout);
+    let mut aliases = Vec::new();
+
+    for line in aliases_text.lines() {
+        if let Some(space_pos) = line.find(' ') {
+            let alias_part = &line[..space_pos];
+            let command_part = &line[space_pos + 1..];
+            
+            if let Some(dot_pos) = alias_part.find('.') {
+                let alias_name = alias_part[dot_pos + 1..].to_string();
+                
+                // Check if this alias was created by our tool
+                let marker_output = Command::new("git")
+                    .args(&[
+                        "config",
+                        "--global",
+                        &format!("alias-tool.{}", alias_name),
+                    ])
+                    .output();
+                
+                let created_by_tool = match marker_output {
+                    Ok(result) => {
+                        let marker_value = String::from_utf8_lossy(&result.stdout);
+                        marker_value.trim() == "git-alias-generator"
+                    }
+                    Err(_) => false,
+                };
+
+                aliases.push(AliasInfo {
+                    name: alias_name,
+                    command: command_part.to_string(),
+                    created_by_tool,
+                });
+            }
+        }
+    }
+
+    Ok(aliases)
+}
+
+#[tauri::command]
+async fn delete_alias(alias_name: String) -> Result<String, String> {
+    // Remove the alias
+    let output = Command::new("git")
+        .args(&["config", "--global", "--unset", &format!("alias.{}", alias_name)])
+        .output()
+        .map_err(|e| format!("Failed to delete alias: {}", e))?;
+
+    if !output.status.success() {
+        let error = String::from_utf8_lossy(&output.stderr);
+        return Err(format!("Failed to delete alias: {}", error));
+    }
+
+    // Remove the tool marker if it exists
+    let _ = Command::new("git")
+        .args(&["config", "--global", "--unset", &format!("alias-tool.{}", alias_name)])
+        .output();
+
+    Ok(format!("Alias '{}' deleted successfully", alias_name))
+}
+
 #[tauri::command]
 async fn save_settings(state: State<'_, AppState>, key: String, value: String) -> Result<(), String> {
     let mut settings = state.lock().unwrap();
@@ -315,6 +405,8 @@ fn main() {
             preview_alias,
             create_alias,
             get_existing_aliases,
+            get_detailed_aliases,
+            delete_alias,
             save_settings,
             get_setting
         ])
diff --git a/src/App.tsx b/src/App.tsx
@@ -1,6 +1,6 @@
 import { useState, useEffect, useCallback } from "react";
 import { invoke } from "@tauri-apps/api/tauri";
-import { Save, Eye, Settings, GitBranch, AlertCircle, CheckCircle, Loader2 } from "lucide-react";
+import { Save, Eye, Settings, GitBranch, AlertCircle, CheckCircle, Loader2, List, Trash2 } from "lucide-react";
 
 interface GitCommand {
   name: string;
@@ -21,6 +21,12 @@ interface AliasResponse {
   alias_command?: string;
 }
 
+interface AliasInfo {
+  name: string;
+  command: string;
+  created_by_tool: boolean;
+}
+
 interface Toast {
   id: number;
   message: string;
@@ -86,7 +92,9 @@ function App() {
   const [isLoading, setIsLoading] = useState(false);
   const [toasts, setToasts] = useState<Toast[]>([]);
   const [existingAliases, setExistingAliases] = useState<string[]>([]);
+  const [detailedAliases, setDetailedAliases] = useState<AliasInfo[]>([]);
   const [showSettings, setShowSettings] = useState(false);
+  const [showAliasViewer, setShowAliasViewer] = useState(false);
 
   const addToast = useCallback((message: string, type: 'success' | 'error') => {
     const id = Date.now();
@@ -126,6 +134,28 @@ function App() {
     }
   }, []);
 
+  const loadDetailedAliases = useCallback(async () => {
+    try {
+      const aliases = await invoke<AliasInfo[]>("get_detailed_aliases");
+      setDetailedAliases(aliases);
+    } catch (error) {
+      console.error("Error loading detailed aliases:", error);
+      addToast("Failed to load aliases", "error");
+    }
+  }, [addToast]);
+
+  const deleteAlias = useCallback(async (aliasName: string) => {
+    try {
+      const result = await invoke<string>("delete_alias", { aliasName });
+      addToast(result, "success");
+      await loadDetailedAliases();
+      await loadExistingAliases();
+    } catch (error) {
+      console.error("Error deleting alias:", error);
+      addToast("Failed to delete alias", "error");
+    }
+  }, [addToast, loadDetailedAliases, loadExistingAliases]);
+
   const loadSettings = useCallback(async () => {
     try {
       const apiKey = await invoke<string | null>("get_setting", { key: "openai_api_key" });
@@ -152,7 +182,10 @@ function App() {
   useEffect(() => {
     loadExistingAliases();
     loadSettings();
-  }, [loadExistingAliases, loadSettings]);
+    if (showAliasViewer) {
+      loadDetailedAliases();
+    }
+  }, [loadExistingAliases, loadSettings, loadDetailedAliases, showAliasViewer]);
 
   useEffect(() => {
     const timer = setTimeout(() => validateAlias(aliasName), 300);
@@ -240,6 +273,9 @@ function App() {
         addToast(result.message, "success");
         setPreviewCommand(result.alias_command || "");
         loadExistingAliases(); // Refresh the list
+        if (showAliasViewer) {
+          loadDetailedAliases();
+        }
       } else {
         addToast(result.message, "error");
       }
@@ -267,13 +303,22 @@ function App() {
       <div className="form-section">
         <div className="flex items-center justify-between">
           <h2>Settings</h2>
-          <button
-            className="btn btn-secondary"
-            onClick={() => setShowSettings(!showSettings)}
-          >
-            <Settings size={16} />
-            {showSettings ? "Hide" : "Show"} Settings
-          </button>
+          <div className="flex gap-2">
+            <button
+              className="btn btn-secondary"
+              onClick={() => setShowAliasViewer(!showAliasViewer)}
+            >
+              <List size={16} />
+              {showAliasViewer ? "Hide" : "View"} Aliases
+            </button>
+            <button
+              className="btn btn-secondary"
+              onClick={() => setShowSettings(!showSettings)}
+            >
+              <Settings size={16} />
+              {showSettings ? "Hide" : "Show"} Settings
+            </button>
+          </div>
         </div>
         
         {showSettings && (
@@ -311,6 +356,47 @@ function App() {
         )}
       </div>
 
+      {/* Alias Viewer */}
+      {showAliasViewer && (
+        <div className="form-section">
+          <div className="alias-viewer">
+            <h3>Existing Git Aliases ({detailedAliases.length})</h3>
+            {detailedAliases.length === 0 ? (
+              <p className="no-aliases">No Git aliases found.</p>
+            ) : (
+              <div className="aliases-grid">
+                {detailedAliases.map(alias => (
+                  <div key={alias.name} className={`alias-card ${alias.created_by_tool ? 'tool-created' : ''}`}>
+                    <div className="alias-card-header">
+                      <div className="alias-name-section">
+                        <code className="alias-name">{alias.name}</code>
+                        {alias.created_by_tool && (
+                          <span className="tool-badge">Created by this tool</span>
+                        )}
+                      </div>
+                      <button
+                        className="btn-icon btn-danger"
+                        onClick={() => {
+                          if (window.confirm(`Are you sure you want to delete the alias '${alias.name}'?`)) {
+                            deleteAlias(alias.name);
+                          }
+                        }}
+                        title="Delete alias"
+                      >
+                        <Trash2 size={14} />
+                      </button>
+                    </div>
+                    <div className="alias-command">
+                      <code>{alias.command}</code>
+                    </div>
+                  </div>
+                ))}
+              </div>
+            )}
+          </div>
+        </div>
+      )}
+
       {/* Alias Name */}
       <div className="form-section">
         <h2>Alias Name</h2>
@@ -321,6 +407,11 @@ function App() {
           onChange={(e) => setAliasName(e.target.value)}
           placeholder="Enter alias name (e.g., 'save', 'sync')"
         />
+        {aliasName.trim() && (
+          <div className="alias-usage-note">
+            Run <code>git {aliasName}</code> from the terminal to execute this command after you save it
+          </div>
+        )}
         {validation && (
           <div className={`validation-message ${
             validation.valid 
diff --git a/src/styles.css b/src/styles.css
