Switch NuGet publishing to Trusted Publishing (OIDC)#75
Merged
Conversation
Agent-Logs-Url: https://github.com/crispthinking/PdqHash/sessions/4d5046f6-12ed-4351-9bff-643d341ef568 Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Switch to TrustedPublishing model for PDQ publishing
Switch NuGet publishing to Trusted Publishing (OIDC)
Apr 1, 2026
corpo-iwillspeak
approved these changes
Apr 1, 2026
There was a problem hiding this comment.
Pull request overview
Updates the NuGet publishing GitHub Actions workflow to use nuget.org Trusted Publishing via OIDC instead of a long-lived NUGET_APIKEY secret.
Changes:
- Adds workflow permissions including
id-token: writeto enable OIDC token exchange. - Introduces a
NuGet/login@v1step (release-only) to obtain a short-lived NuGet API key. - Switches nuget.org publish to use
steps.login.outputs.NUGET_API_KEYinstead ofsecrets.NUGET_APIKEY.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ghost
previously approved these changes
Apr 1, 2026
corpo-iwillspeak
requested changes
Apr 7, 2026
corpo-iwillspeak
left a comment
corpo-iwillspeak
left a comment
Contributor
There was a problem hiding this comment.
Address the selected PR comment
Agent-Logs-Url: https://github.com/crispthinking/PdqHash/sessions/616ec821-bb44-4f25-9f9f-6b4cbfad9db9 Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
Contributor
Author
Done in b5e6533. Removed the top-level
|
corpo-iwillspeak
approved these changes
Apr 7, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ghost
approved these changes
Apr 7, 2026
corpo-iwillspeak
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/publish.ymlto use Trusted Publishing (OIDC) modelpermissionsblockbuildjob:contents: read,checks: write(for test reporter)deployjob:packages: write(GitHub Packages),id-token: write(OIDC)