feat: allow insecure grpc option for local testing#65
Open
anna-singleton-resolver wants to merge 5 commits into
Open
feat: allow insecure grpc option for local testing#65anna-singleton-resolver wants to merge 5 commits into
anna-singleton-resolver wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit “unsafe/insecure” toggle to the Athena gRPC client to support local development scenarios where TLS isn’t used, and wires that toggle through the example CLI.
Changes:
- Introduces
UnsafeAllowInsecureinAthenaApiClientConfiguration. - Switches gRPC channel credential setup to optionally use
ChannelCredentials.Insecureand setsUnsafeUseInsecureChannelCallCredentialsaccordingly. - Adds
--unsafe-insecureto the example CLI and passes it into client configuration for multiple commands.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Resolver.Athena.Client/ApiClient/AthenaApiClientConfiguration.cs | Adds configuration flag to permit insecure connections (intended for local testing). |
| src/Resolver.Athena.Client/ApiClient/AthenaApiClient.cs | Uses the new flag to choose secure vs insecure gRPC channel credentials and channel options. |
| examples/Resolver.Athena.CliClient/Program.cs | Registers the new CLI option on the root command. |
| examples/Resolver.Athena.CliClient/CliUtilities.cs | Defines the new --unsafe-insecure option. |
| examples/Resolver.Athena.CliClient/ListDeploymentsCommand.cs | Passes the CLI insecure flag into AddAthenaClient configuration. |
| examples/Resolver.Athena.CliClient/ClassifySingleCommand.cs | Passes the CLI insecure flag into AddAthenaClient configuration. |
| examples/Resolver.Athena.CliClient/ClassifyCommand.cs | Passes the CLI insecure flag into AddAthenaClient configuration. |
| examples/Resolver.Athena.CliClient/ClassifyDataflowCommand.cs | Passes the CLI insecure flag into AddAthenaDataflowClient configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
corpo-iwillspeak
approved these changes
Mar 30, 2026
corpo-iwillspeak
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.