refactor: extract parseAudience type guard to shared location

- Add AthenaAudience type, VALID_AUDIENCES array, and parseAudience()
  function to authenticationManager.ts
- Export from SDK index for consumer use
- Update e2e test, samples to use shared parseAudience function
- Removes unsafe type assertions in favor of runtime validation

Author: corpo-iwillspeak

__tests__/functional/e2e.functional.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, beforeAll } from 'vitest';
-import { ClassifierSdk, ImageFormat } from '../../src';
+import { ClassifierSdk, ImageFormat, parseAudience } from '../../src';
 import fs from 'fs';
 import path from 'path';
 
@@ -64,7 +64,7 @@ describe('E2E Test Cases', () => {
           process.env.VITE_OAUTH_ISSUER ?? 'https://crispthinking.auth0.com/',
         clientId: process.env.VITE_ATHENA_CLIENT_ID ?? '',
         clientSecret: process.env.VITE_ATHENA_CLIENT_SECRET ?? '',
-        audience: (process.env.VITE_ATHENA_AUDIENCE as 'crisp-athena-live' | 'crisp-athena-dev' | 'crisp-athena-qa') ?? 'crisp-athena-live',
+        audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE),
         scope: 'manage:classify',
       },
     });

samples/e2e-testcases/index.ts

@@ -8,7 +8,7 @@
  * against expected outputs.
  */
 
-import { ClassifierSdk, ImageFormat } from '@crispthinking/athena-classifier-sdk';
+import { ClassifierSdk, ImageFormat, parseAudience } from '@crispthinking/athena-classifier-sdk';
 import fs from 'fs';
 import path from 'path';
 import { fileURLToPath } from 'url';
@@ -26,7 +26,7 @@ const CONFIG = {
   affiliate: process.env.ATHENA_AFFILIATE,
   issuerUrl: process.env.ATHENA_ISSUER_URL || 'https://crispthinking.auth0.com/',
   grpcAddress: process.env.ATHENA_GRPC_ADDRESS || 'trust-messages-global.crispthinking.com:443',
-  audience: process.env.ATHENA_AUDIENCE || 'crisp-athena-live'
+  audience: parseAudience(process.env.ATHENA_AUDIENCE)
 };
 
 /**

samples/hash-server/index.ts

@@ -1,4 +1,4 @@
-import { ClassifierSdk, HashType, ImageFormat, RequestEncoding, type ClassifyImageInput } from '@crispthinking/athena-classifier-sdk';
+import { ClassifierSdk, HashType, ImageFormat, RequestEncoding, parseAudience, type ClassifyImageInput } from '@crispthinking/athena-classifier-sdk';
 import express from 'express';
 import type { Request, Response, NextFunction } from 'express';
 import multer from 'multer';
@@ -147,7 +147,7 @@ const sdk = new ClassifierSdk({
     clientId: CONFIG.clientId!,
     clientSecret: CONFIG.clientSecret!,
     issuerUrl: CONFIG.issuerUrl!,
-    audience: CONFIG.audience! as 'crisp-athena-live' | 'crisp-athena-dev' | 'crisp-athena-qa'
+    audience: parseAudience(CONFIG.audience)
   },
   grpcAddress: CONFIG.grpcAddress!,
   affiliate: CONFIG.affiliate!,

src/authenticationManager.ts

@@ -8,6 +8,30 @@ import {
 import * as grpc from '@grpc/grpc-js';
 import { jwtDecode, type JwtPayload } from 'jwt-decode';
 
+/**
+ * Valid audience values for the Athena SDK.
+ */
+export type AthenaAudience = 'crisp-athena-live' | 'crisp-athena-dev' | 'crisp-athena-qa';
+
+/**
+ * List of valid audience values.
+ */
+export const VALID_AUDIENCES: readonly AthenaAudience[] = ['crisp-athena-live', 'crisp-athena-dev', 'crisp-athena-qa'] as const;
+
+/**
+ * Type guard to validate and parse an audience string.
+ * Returns the validated audience value or a default if invalid/undefined.
+ * @param value The string value to validate
+ * @param defaultValue The default audience if value is invalid (default: 'crisp-athena-live')
+ * @returns A valid AthenaAudience value
+ */
+export function parseAudience(value: string | undefined, defaultValue: AthenaAudience = 'crisp-athena-live'): AthenaAudience {
+  if (value && VALID_AUDIENCES.includes(value as AthenaAudience)) {
+    return value as AthenaAudience;
+  }
+  return defaultValue;
+}
+
 /**
  * Options for configuring the AuthenticationManager.
  */
@@ -23,7 +47,7 @@ export type AuthenticationOptions = {
   /** OAuth scope to request. */
   scope?: string;
   /** OAuth audience to request. */
-  audience?: 'crisp-athena-live' | 'crisp-athena-dev' | 'crisp-athena-qa';
+  audience?: AthenaAudience;
 };
 
 /**

src/index.ts

@@ -391,3 +391,9 @@ export class ClassifierSdk extends (EventEmitter as new () => TypedEventEmitter<
 export * from './generated/athena/models.js';
 export { ClassifierServiceClient } from './generated/athena/athena.js';
 export * from './hashing.js';
+export {
+  type AuthenticationOptions,
+  type AthenaAudience,
+  VALID_AUDIENCES,
+  parseAudience,
+} from './authenticationManager.js';