Skip to content

Seperate out the functional tests so we don't run them in PRs#11

Merged
snus-kin merged 9 commits into
mainfrom
feature/seperate-functional-tests
Sep 5, 2025
Merged

Seperate out the functional tests so we don't run them in PRs#11
snus-kin merged 9 commits into
mainfrom
feature/seperate-functional-tests

Conversation

@snus-kin

@snus-kin snus-kin commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

snus-kin and others added 7 commits September 5, 2025 10:16
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@snus-kin snus-kin requested a review from Copilot September 5, 2025 09:57
Comment thread .github/workflows/functional-tests.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates functional tests from unit tests to prevent functional tests from running in PR pipelines. Functional tests require external dependencies and environment variables, while unit tests are fast and can run in isolation.

  • Adds separate configuration for functional vs unit test execution
  • Updates CI workflow to only run unit tests for PR builds
  • Creates dedicated workflow for functional tests with manual trigger

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Adds separate test commands and improved npm scripts for different test types
__tests__/vitest.config.ts Updates unit test configuration to exclude functional tests
__tests__/vitest.functional.config.ts New configuration file dedicated to functional tests
__tests__/unit/main.test.ts Converts integration tests to proper unit tests with mocking
__tests__/functional/main.functional.test.ts Moves integration tests to functional test suite
.github/workflows/nodejs.yml Updates main CI to only run unit tests
.github/workflows/functional-tests.yml New workflow for functional tests with manual trigger
eslint.config.mjs Improves ESLint configuration formatting and adds ignore patterns
.pre-commit-config.yaml Adds pre-commit hooks configuration
.gitmodules Configures protobuf submodule
README.md Updates documentation for new test structure and development setup
src/athena/athena.ts Adds new error code enums to protobuf-generated code
Comments suppressed due to low confidence (1)

package.json:1

  • There's a spelling error in the PR title. It should be 'Separate' instead of 'Seperate'.
{

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread __tests__/functional/main.functional.test.ts
Comment thread __tests__/functional/main.functional.test.ts
Comment thread __tests__/functional/main.functional.test.ts
…n permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@snus-kin snus-kin enabled auto-merge (squash) September 5, 2025 10:11
iwillspeak
iwillspeak previously approved these changes Sep 5, 2025
@snus-kin snus-kin dismissed iwillspeak’s stale review September 5, 2025 10:55

The merge-base changed after approval.

@snus-kin snus-kin requested a review from iwillspeak September 5, 2025 11:17
@snus-kin snus-kin merged commit cb9c08d into main Sep 5, 2025
7 checks passed
@snus-kin snus-kin deleted the feature/seperate-functional-tests branch September 5, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants