Seperate out the functional tests so we don't run them in PRs#11
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR separates functional tests from unit tests to prevent functional tests from running in PR pipelines. Functional tests require external dependencies and environment variables, while unit tests are fast and can run in isolation.
- Adds separate configuration for functional vs unit test execution
- Updates CI workflow to only run unit tests for PR builds
- Creates dedicated workflow for functional tests with manual trigger
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds separate test commands and improved npm scripts for different test types |
__tests__/vitest.config.ts |
Updates unit test configuration to exclude functional tests |
__tests__/vitest.functional.config.ts |
New configuration file dedicated to functional tests |
__tests__/unit/main.test.ts |
Converts integration tests to proper unit tests with mocking |
__tests__/functional/main.functional.test.ts |
Moves integration tests to functional test suite |
.github/workflows/nodejs.yml |
Updates main CI to only run unit tests |
.github/workflows/functional-tests.yml |
New workflow for functional tests with manual trigger |
eslint.config.mjs |
Improves ESLint configuration formatting and adds ignore patterns |
.pre-commit-config.yaml |
Adds pre-commit hooks configuration |
.gitmodules |
Configures protobuf submodule |
README.md |
Updates documentation for new test structure and development setup |
src/athena/athena.ts |
Adds new error code enums to protobuf-generated code |
Comments suppressed due to low confidence (1)
package.json:1
- There's a spelling error in the PR title. It should be 'Separate' instead of 'Seperate'.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
iwillspeak
previously approved these changes
Sep 5, 2025
The merge-base changed after approval.
anna-singleton-resolver
approved these changes
Sep 5, 2025
iwillspeak
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.