fix: restore typed emit() on ClassifierSdk; update smoke test comments

[corpo-iwillspeak]

Switching ClassifierSdk from TypedEventEmitter<ClassifierEvents> to plain EventEmitter left emit() untyped (emit(string | symbol, ...any[])), while on/once/off already had typed overrides. Smoke test comments still hardcoded localhost:50051 after grpcAddress was made configurable via VITE_ATHENA_GRPC_ADDRESS.

Changes

• src/index.ts — adds a typed emit override matching the existing on/once/off pattern, restoring full public API type-safety without reintroducing the TypedEventEmitter cast that broke the release build:

public override emit<U extends keyof ClassifierEvents>(
  event: U,
  ...args: Parameters<ClassifierEvents[U]>
): boolean {
  return super.emit(event, ...args);
}

• __tests__/functional/main.functional.test.ts — replaces hardcoded localhost:50051 references in smoke test setup comments with accurate guidance: address comes from VITE_ATHENA_GRPC_ADDRESS, falling back to the SDK default.

[Copilot]

Pull request overview

This PR updates the test suite to stop requesting explicit OAuth scope values, switching functional tests to pass an audience parsed via parseAudience, and extends functional tests to configure the SDK’s gRPC endpoint via grpcAddress.

Changes:

• Remove scope from unit and functional test authentication configurations; update the auth manager unit test mock expectation accordingly.
• Update functional tests to set audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE) and pass grpcAddress from VITE_ATHENA_GRPC_ADDRESS.
• Fix a functional test assertion to correctly verify response.classifications is an array.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/unit/module-import.test.ts	Removes scope from the SDK instantiation used for import/creation verification.
tests/unit/main.test.ts	Removes scope from several ClassifierSdk constructor tests.
tests/unit/authenticationManager.test.ts	Removes scope from options and updates the clientCredentialsGrant expectation to match the no-scope call shape.
tests/functional/main.functional.test.ts	Switches functional tests to audience via parseAudience, adds grpcAddress, and fixes an assertion on classifications.
tests/functional/e2e.functional.test.ts	Removes scope from E2E test authentication config (audience remains).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[snus-kin]

Dunno what yo udid the break the build but it seems unrelated to the changes in this PR.

[corpo-iwillspeak]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Updated all three smoke test comments in main.functional.test.ts to replace the hardcoded localhost:50051 reference with a description that the gRPC address comes from VITE_ATHENA_GRPC_ADDRESS, falling back to the SDK default if not set. Commit: 266838c

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• node-precompiled-binaries.grpc.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/athena-nodejs-client/athena-nodejs-client/node_modules/.bin/node-pre-gyp install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)