chore: copilot minor doc & style suggestions

Author: anna-singleton-resolver

tests/functional/test_invalid_oauth.py

@@ -41,7 +41,7 @@ async def test_invalid_secret(athena_options: AthenaOptions) -> None:
 async def test_invalid_clientid(athena_options: AthenaOptions) -> None:
     """Test that an invalid OAuth client secret is rejected."""
     load_dotenv()
-    invalid_client_secret = os.environ["OAUTH_CLIENT_SECRET"]
+    client_secret = os.environ["OAUTH_CLIENT_SECRET"]
     client_id = "this_is_not_a_valid_client_id"
     auth_url = os.getenv(
         "OAUTH_AUTH_URL", "https://crispthinking.auth0.com/oauth/token"
@@ -50,7 +50,7 @@ async def test_invalid_clientid(athena_options: AthenaOptions) -> None:
 
     credential_helper = CredentialHelper(
         client_id=client_id,
-        client_secret=invalid_client_secret,
+        client_secret=client_secret,
         auth_url=auth_url,
         audience=audience,
     )
@@ -64,9 +64,9 @@ async def test_invalid_clientid(athena_options: AthenaOptions) -> None:
 @pytest.mark.asyncio
 @pytest.mark.functional
 async def test_invalid_audience(athena_options: AthenaOptions) -> None:
-    """Test that an invalid OAuth client secret is rejected."""
+    """Test that an invalid OAuth audience is rejected."""
     load_dotenv()
-    invalid_client_secret = os.environ["OAUTH_CLIENT_SECRET"]
+    client_secret = os.environ["OAUTH_CLIENT_SECRET"]
     client_id = "this_is_not_a_valid_client_id"
     auth_url = os.getenv(
         "OAUTH_AUTH_URL", "https://crispthinking.auth0.com/oauth/token"
@@ -75,7 +75,7 @@ async def test_invalid_audience(athena_options: AthenaOptions) -> None:
 
     credential_helper = CredentialHelper(
         client_id=client_id,
-        client_secret=invalid_client_secret,
+        client_secret=client_secret,
         auth_url=auth_url,
         audience=audience,
     )

tests/functional/test_invalid_static_token_auth.py

@@ -61,9 +61,7 @@ async def test_platform_token_is_rejected(
 @pytest.mark.asyncio
 @pytest.mark.functional
 async def test_expired_token_is_rejected(athena_options: AthenaOptions) -> None:
-    """Test that a standard Resolver platform token is rejected.
-
-    Only static tokens generated for Athena access should be accepted."""
+    """Test that an expired token is rejected."""
     load_dotenv()
     platform_token = os.environ["ATHENA_TEST_EXPIRED_TOKEN"]
     channel = create_channel(athena_options.host, platform_token)