Skip to content

Commit 246a1fa

Browse files
committed
refactor: use backend 'Browser appearance' string
- "Card Browser Appearance" - card_template_editor_menu_card_browser_appearance - "Browser appearance" - card_template_browser_appearance_title Assisted-by: Claude Opus 4.7
1 parent 1df3c38 commit 246a1fa

9 files changed

Lines changed: 12 additions & 11 deletions

File tree

AnkiDroid/src/main/AndroidManifest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,6 @@
488488
</activity>
489489
<activity
490490
android:name=".CardTemplateBrowserAppearanceEditor"
491-
android:label="@string/card_template_browser_appearance_title"
492491
android:exported="false"
493492
android:configChanges="keyboardHidden|orientation|screenSize"
494493
/>

AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateBrowserAppearanceEditor.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ class CardTemplateBrowserAppearanceEditor : AnkiActivity(R.layout.activity_card_
139139
discardChangesCallback.isEnabled = hasChanges()
140140

141141
enableToolbar()
142-
setTitle(R.string.card_template_browser_appearance_title)
142+
title = TR.sentenceCase.browserAppearance
143143
}
144144

145145
private fun answerHasChanged(intent: Intent): Boolean = intent.getStringExtra(INTENT_ANSWER_FORMAT) != answerFormat

AnkiDroid/src/main/java/com/ichi2/anki/CardTemplateEditor.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1040,7 +1040,8 @@ open class CardTemplateEditor : AnkiActivity(R.layout.activity_card_template_edi
10401040
* Setups the part of the menu that can be used either in template editor or in previewer fragment.
10411041
*/
10421042
fun setupCommonMenu(menu: Menu) {
1043-
menu.findItem(R.id.action_restore_to_default).title = CollectionManager.TR.cardTemplatesRestoreToDefault()
1043+
menu.findItem(R.id.action_restore_to_default).title = TR.cardTemplatesRestoreToDefault()
1044+
menu.findItem(R.id.action_card_browser_appearance).title = TR.sentenceCase.browserAppearance
10441045
if (noteTypeCreatesDynamicNumberOfNotes()) {
10451046
Timber.d("Editing cloze/occlusion note type, disabling add/delete card template and deck override functionality")
10461047
menu.findItem(R.id.action_add).isVisible = false

AnkiDroid/src/main/java/com/ichi2/anki/ui/internationalization/SentenceCase.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,12 @@ object SentenceCase {
217217

218218
context(_: Fragment)
219219
val ankiWebAccount get() = TR.preferencesAccount().toSentenceCase(R.string.sentence_ankiweb_account)
220+
221+
context(_: Context)
222+
val browserAppearance get() = TR.browsingBrowserAppearance().toSentenceCase(R.string.sentence_browser_appearance)
223+
224+
context(_: Fragment)
225+
val browserAppearance get() = TR.browsingBrowserAppearance().toSentenceCase(R.string.sentence_browser_appearance)
220226
}
221227

222228
/**

AnkiDroid/src/main/res/menu/card_template_editor.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<item
3535
android:id="@+id/action_card_browser_appearance"
3636
android:icon="@drawable/ic_view_list_white_24dp"
37-
android:title="@string/card_template_editor_menu_card_browser_appearance"
37+
tools:title="Browser appearance"
3838
ankidroid:showAsAction="ifRoom"/>
3939
<!-- never show - no icon. Title is dynamic (on/off) -->
4040
<item

AnkiDroid/src/main/res/values/01-core.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@
110110

111111
<!-- Card template editor -->
112112
<string name="title_activity_template_editor">Card types</string>
113-
<string name="card_template_editor_menu_card_browser_appearance" maxLength="28">Card Browser Appearance</string>
114113
<string name="card_template_editor_deck_override" maxLength="28">Deck override</string>
115114
<string name="card_template_editor_insert_field" maxLength="28">Insert field</string>
116115
<string name="card_template_editor_select_field">Select field</string>
@@ -126,11 +125,6 @@
126125
<string name="card_template_editor_save_error">Unable to save card template changes: %s</string>
127126
<string name="template_for_current_card_deleted">The card type for the current card was deleted.</string>
128127

129-
<!-- Card Browser Appearance -->
130-
<string name="card_template_browser_appearance_title">Browser appearance</string>
131-
132-
<!-- card Info -->
133-
134128
<!-- Permissions -->
135129
<string name="read_write_permission_label">Read and write to the AnkiDroid database</string>
136130
<string name="read_write_permission_description">access existing notes, cards, note types, and decks, as well as create new ones</string>

AnkiDroid/src/main/res/values/sentence-case.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,4 +77,5 @@ undoActionUndone()
7777
<string name="sentence_mark_note">Mark note</string>
7878
<string name="sentence_delete_note">Delete note</string>
7979
<string name="sentence_ankiweb_account" maxLength="41">AnkiWeb account</string>
80+
<string name="sentence_browser_appearance">Browser appearance</string>
8081
</resources>

AnkiDroid/src/test/java/com/ichi2/anki/TranslationTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,6 @@ class TranslationTest : RobolectricTest() {
340340
"Answer buttons", // R.string.answer_buttons | TR.statisticsAnswerButtonsTitle()
341341
"Answer good", // R.string.answer_good | TR.deckConfigAnswerGood()
342342
"Answer hard", // R.string.answer_hard | TR.deckConfigAnswerHard()
343-
"Browser appearance", // R.string.card_template_browser_appearance_title | TR.browsingBrowserAppearance()
344343
"Browser options", // R.string.browser_options_dialog_heading | TR.browsingBrowserOptions()
345344
"Change deck", // R.string.card_browser_change_deck | TR.browsingChangeDeck()
346345
"Copy debug info", // R.string.feedback_copy_debug

AnkiDroid/src/test/java/com/ichi2/anki/ui/internationalization/SentenceCaseTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ class SentenceCaseTest : RobolectricTest() {
7979
assertThat(TR.sentenceCase.deleteNote, equalTo("Delete note"))
8080
assertThat(TR.sentenceCase.previousCardInfo, equalTo("Previous card info"))
8181
assertThat(TR.sentenceCase.ankiWebAccount, equalTo("AnkiWeb account"))
82+
assertThat(TR.sentenceCase.browserAppearance, equalTo("Browser appearance"))
8283

8384
assertThat("syncMediaLogTitle", TR.syncMediaLogTitle(), equalTo("Media Sync Log"))
8485
assertThat(TR.sentenceCase.mediaSyncLog, equalTo("Media sync log"))

0 commit comments

Comments
 (0)