Commit 259df96
� This is a combination of 6 commits.
� This is the 1st commit message:
added test files for currentdeckid()
mark test as flaky
Issue 19729
fix(deckpicker): Added contentDescription to sync and add card buttons
deprecation(libanki): prefer `defaultsForAdding()` over `current()`
Deprecates Notetypes.current() in favor of col.defaultsForAdding()
Fixes: 19650
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
chore: log 'Activity with no Application' error
It's likely that there's another cause other than the backup manager
Diagnostics for issue 19050
style: fix dangling top-level KDocs
This breaks KtLint 1.8.0
> A dangling toplevel KDoc is not allowed (cannot be auto-corrected)
* modify `libs.versions.toml` to use `ktlint = '1.8.0'`
* ./gradlew ktLintFormat
* revert all changes
* manually fix warnings, searching for 'dangling'
* manually check fixes ensuring only top-level comments
are processed
Issue 19614 - updating ktLint
docs(github): Explain workflows
Quality Checks can be linked to from other pages as an onboarding guide
https://github.com/ankidroid/Anki-Android/tree/main/.github/workflows/README.md#quality-checks
docs(deps): improve AndroidX lifecycle-process
* link changelogs
* rename to 'androidxLifecycleProcess'
* make location consistent with other libraries
Added in 7f7cd37
Disable "Scroll toolbar" if toolbar is not shown
In the note editor's overflow menu,
disable the "Scroll toolbar" option
if the toolbar (for HTML formatting) is not shown.
Add comprehensive tests for Card.currentDeckId()
- Test normal deck scenario (oDid=0 returns did)
- Test filtered deck scenario (oDid takes priority)
- Test precedence when both IDs are positive
- Test real-world filtered deck usage
- Test normal deck default behavior
- Test edge case where both IDs are same
Addresses @NeedsTest annotation on currentDeckId() method
Update Card.kt
Update CardTest.kt
chore: fix warnings in ExifUtil and UniqueArrayList
* Convert var to val in ExifUtil
* Fix KDoc references in UniqueArrayList
Issue: 13282
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
Add comprehensive tests for Card.currentDeckId()
- Test normal deck scenario (oDid=0 returns did)
- Test filtered deck scenario (oDid takes priority)
- Test precedence when both IDs are positive
- Test real-world filtered deck usage
- Test normal deck default behavior
- Test edge case where both IDs are same
Addresses @NeedsTest annotation on currentDeckId() method
Update Card.kt
Update CardTest.kt
Update Card.kt
Update Card.kt
Update CardTest.kt
Update CardTest.kt
Update CardTest.kt
Update Card.kt
Update CardTest.kt
Update CardTest.kt
Update CardTest.kt
Update tests to verify functionality calling currentDeckId()
Update CardTest.kt
Update CardTest.kt
Update CardTest.kt
Update CardTest.kt
Update CardTest.kt
Revert "added test files for currentdeckid()"
This reverts commit 1b3060e.
� This is the commit message #2:
Update Card.kt
� This is the commit message #3:
Update CardTest.kt
� This is the commit message #4:
Update Card.kt
� This is the commit message #5:
Update CardTest.kt
� This is the commit message #6:
Revert "Update Card.kt & Cardtest.kt"
This reverts commit 5bc3121.
Test files in cardtest.kt & card.kt1 parent 036707c commit 259df96
2 files changed
Lines changed: 123 additions & 3 deletions
File tree
- libanki/src
- main/java/com/ichi2/anki/libanki
- test/java/com/ichi2/anki/libanki
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
237 | 236 | | |
238 | 237 | | |
239 | 238 | | |
240 | | - | |
241 | 239 | | |
242 | 240 | | |
243 | 241 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| 29 | + | |
28 | 30 | | |
| 31 | + | |
29 | 32 | | |
30 | 33 | | |
| 34 | + | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| |||
232 | 236 | | |
233 | 237 | | |
234 | 238 | | |
235 | | - | |
| 239 | + | |
| 240 | + | |
236 | 241 | | |
237 | 242 | | |
238 | 243 | | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
239 | 361 | | |
240 | 362 | | |
241 | 363 | | |
| |||
0 commit comments