fix: API persist deck description on insert

Author: criticalAY

AnkiDroid/src/androidTest/java/com/ichi2/anki/tests/ContentProviderTest.kt

@@ -1802,6 +1802,51 @@ class ContentProviderTest : InstrumentedTest() {
         }
     }
 
+    @Test
+    fun testInsertDeckWithDescription() {
+        val deckName = "test_deck_with_desc"
+        val deckDesc = "This is the deck description"
+        val values =
+            ContentValues().apply {
+                put(FlashCardsContract.Deck.DECK_NAME, deckName)
+                put(FlashCardsContract.Deck.DECK_DESC, deckDesc)
+            }
+        val newDeckUri = contentResolver.insert(FlashCardsContract.Deck.CONTENT_ALL_URI, values)
+        assertNotNull("Check that URI returned from insert is not null", newDeckUri)
+        val newDeckId = newDeckUri!!.lastPathSegment!!.toLong()
+        testDeckIds.add(newDeckId)
+
+        val reopenedCol = reopenCol()
+        val savedDeck = reopenedCol.decks.getLegacy(newDeckId)
+        assertNotNull("Check that the inserted deck exists", savedDeck)
+        assertEquals(
+            "Check that the deck description was persisted",
+            deckDesc,
+            savedDeck!!.description,
+        )
+    }
+
+    @Test
+    fun testInsertDeckWithoutDescription() {
+        val deckName = "test_deck_no_desc"
+        val values =
+            ContentValues().apply {
+                put(FlashCardsContract.Deck.DECK_NAME, deckName)
+            }
+        val newDeckUri = contentResolver.insert(FlashCardsContract.Deck.CONTENT_ALL_URI, values)
+        assertNotNull("Check that URI returned from insert is not null", newDeckUri)
+        val newDeckId = newDeckUri!!.lastPathSegment!!.toLong()
+        testDeckIds.add(newDeckId)
+
+        val savedDeck = col.decks.getLegacy(newDeckId)
+        assertNotNull("Check that the inserted deck exists", savedDeck)
+        assertEquals(
+            "Description should default to empty when not provided",
+            "",
+            savedDeck!!.description,
+        )
+    }
+
     /**
      * Test that query for the next card in the schedule returns a valid result without any deck selector
      */

AnkiDroid/src/main/java/com/ichi2/anki/provider/CardContentProvider.kt

@@ -1034,18 +1034,10 @@ class CardContentProvider : ContentProvider() {
                     throw IllegalArgumentException(filteredSubdeck.message)
                 }
                 val deck: Deck = col.decks.getLegacy(did)!!
-                @KotlinCleanup("remove the null check if deck is found to be not null in DeckManager.get(Long)")
-                @Suppress("SENSELESS_COMPARISON")
-                if (deck != null) {
-                    try {
-                        val deckDesc = values.getAsString(FlashCardsContract.Deck.DECK_DESC)
-                        if (deckDesc != null) {
-                            deck.put("desc", deckDesc)
-                        }
-                    } catch (e: JSONException) {
-                        Timber.e(e, "Could not set a field of new deck %s", deckName)
-                        return null
-                    }
+                val deckDesc = values.getAsString(FlashCardsContract.Deck.DECK_DESC)
+                if (deckDesc != null) {
+                    deck.description = deckDesc
+                    col.decks.save(deck)
                 }
                 Uri.withAppendedPath(FlashCardsContract.Deck.CONTENT_ALL_URI, did.toString())
             }