Skip to content

Commit 9c84bfe

Browse files
committed
Fix #682 gemspec Faraday constraint regression
1 parent 3091d51 commit 9c84bfe

2 files changed

Lines changed: 23 additions & 7 deletions

File tree

ruby_llm.gemspec

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,10 @@ Gem::Specification.new do |spec|
4242
# Runtime dependencies
4343
spec.add_dependency 'base64'
4444
spec.add_dependency 'event_stream_parser', '~> 1'
45-
if Gem::Version.new(Gem.ruby_version) >= Gem::Version.new('4.0')
46-
spec.add_dependency 'faraday', '>= 2.0'
47-
spec.add_dependency 'faraday-retry', '>= 2.0'
48-
else
49-
spec.add_dependency 'faraday', ENV['FARADAY_VERSION'] || '>= 1.10.0'
50-
spec.add_dependency 'faraday-retry', '>= 1'
51-
end
45+
spec.add_dependency 'faraday', ENV['FARADAY_VERSION'] || '>= 1.10.0'
5246
spec.add_dependency 'faraday-multipart', '>= 1'
5347
spec.add_dependency 'faraday-net_http', '>= 1'
48+
spec.add_dependency 'faraday-retry', '>= 1'
5449
spec.add_dependency 'marcel', '~> 1'
5550
spec.add_dependency 'ruby_llm-schema', '~> 0'
5651
spec.add_dependency 'zeitwerk', '~> 2'

spec/ruby_llm_gemspec_spec.rb

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# frozen_string_literal: true
2+
3+
require 'spec_helper'
4+
5+
# rubocop:disable RSpec/DescribeClass
6+
RSpec.describe 'ruby_llm.gemspec' do
7+
subject(:gemspec) { Gem::Specification.load(File.expand_path('../ruby_llm.gemspec', __dir__)) }
8+
9+
def runtime_dependency(name)
10+
gemspec.dependencies.find { |dependency| dependency.type == :runtime && dependency.name == name }
11+
end
12+
13+
it 'keeps faraday compatible with Ruby < 4.0' do
14+
expect(runtime_dependency('faraday').requirement.to_s).to eq('>= 1.10.0')
15+
end
16+
17+
it 'keeps faraday-retry compatible with Faraday v1 and v2' do
18+
expect(runtime_dependency('faraday-retry').requirement.to_s).to eq('>= 1')
19+
end
20+
end
21+
# rubocop:enable RSpec/DescribeClass

0 commit comments

Comments
 (0)