Skip to content

Fix OpenAI search model temperature normalization#699

Closed
Gujiassh wants to merge 1 commit intocrmne:mainfrom
Gujiassh:fix/openai-search-temperature
Closed

Fix OpenAI search model temperature normalization#699
Gujiassh wants to merge 1 commit intocrmne:mainfrom
Gujiassh:fix/openai-search-temperature

Conversation

@Gujiassh
Copy link
Copy Markdown

Summary

  • make OpenAI search models drop temperature before the broader gpt-5 normalization branch runs
  • add regression coverage for gpt-5-search-api alongside the existing search model expectations

Testing

  • bundle exec rspec spec/ruby_llm/providers/open_ai/temperature_spec.rb -e \"returns nil for search models\"
  • bundle exec rspec spec/ruby_llm/providers/open_ai/temperature_spec.rb
  • bundle exec rubocop lib/ruby_llm/providers/openai/temperature.rb spec/ruby_llm/providers/open_ai/temperature_spec.rb

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@Gujiassh
Copy link
Copy Markdown
Author

Closing this stale radar PR to keep the queue clean: it has been open for weeks without maintainer response, and I am not going to keep it in the active follow-up set without renewed upstream interest.

@Gujiassh Gujiassh closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant