Skip to content

Fixes issue #744: nil response bodies in openrouter responses #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kplawver wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes issue #744: nil response bodies in openrouter responses #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9662d9
Fixes issue #744: nil response bodies in openrouter responses
kplawver Apr 24, 2026
8f5c12c
Swaps .blank? check for .nil? || .empty? to remove ActiveSupport depe…
kplawver May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby_llm/providers/openrouter/chat.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def render_payload(messages, tools:, temperature:, model:, stream: false, schema

def parse_completion_response(response)
data = response.body
return if data.empty?
return if data.nil? || data.blank?

raise Error.new(response, data.dig('error', 'message')) if data.dig('error', 'message')

Expand Down
11 changes: 10 additions & 1 deletion spec/ruby_llm/providers/open_router/chat_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
require 'spec_helper'

RSpec.describe RubyLLM::Providers::OpenRouter::Chat do
let(:model) { instance_double(RubyLLM::Model::Info, id: 'anthropic/claude-haiku-4.5') }

describe '.render_payload' do
let(:model) { instance_double(RubyLLM::Model::Info, id: 'anthropic/claude-haiku-4.5') }
let(:messages) { [RubyLLM::Message.new(role: :user, content: 'Hello')] }

before do
Expand Down Expand Up @@ -63,4 +64,12 @@
expect(payload[:response_format][:json_schema][:strict]).to be(false)
end
end

describe '.parse_completion_response' do
let(:response) { instance_double(Faraday::Response, body: nil) }

it "doesn't throw an error when response is nil" do
expect { described_class.parse_completion_response(response) }.not_to raise_error
end
end
end