ci: add always-green wrapper job for branch protection compatibility#57
Merged
Conversation
Docs-only PRs skip all conditional jobs (lint, test, etc.) via paths-filter, which leaves required status checks in 'skipping' state. GitHub treats skipped != passed, so merge is blocked. Fix: add a ci wrapper job that depends on all conditional jobs and runs with if: always(). It passes when deps are either passed or skipped, and fails when any dep fails or is cancelled. Branch protection ruleset updated to require only 'ci' instead of 'test (3.10/11/12)'.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Docs-only PRs (e.g. #53) have all jobs in 'skipping' state because
paths-filter correctly determines no source changed. However GitHub
branch protection treats 'skipped' as not equal to 'passed', so the PR
cannot be merged.
Fix
Add a
ciwrapper job that:needsif: always()so it is never skippedsuccessorskippedfailureorcancelledAlso update the branch protection ruleset (via API) to require only
ciinstead of the three
test (3.10/11/12)checks.Test plan
cireports green)