feat!: remove auto-fix subsystem (mrt fix, clean-backups) — out of scope#88
Closed
croc100 wants to merge 2 commits into
Closed
feat!: remove auto-fix subsystem (mrt fix, clean-backups) — out of scope#88croc100 wants to merge 2 commits into
croc100 wants to merge 2 commits into
Conversation
Migration code generation is a transform, not a verify operation, and does not belong in a rollback-testing tool. Removes ~1100 lines: - core/fixer.py, adapters/django_fixer.py, commands/fix.py (mrt fix) - commands/clean_backups.py (mrt clean-backups — only cleaned the _mrt_backups table that mrt fix-generated migrations created) - fixable field from mrt check --format json output - associated tests and the django_fixer_app test fixture - docs, roadmap, and contributing references BREAKING CHANGE: mrt fix and mrt clean-backups commands are gone, and the JSON findings no longer include a fixable field. Pin pytest-mrt<1.5.0 if you depend on auto-fix. Bumped to 1.5.0.
Owner
Author
|
Superseded by new PR based directly on main (branch: feat/remove-fixer-v2). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Migration code generation is a transform, not a verify operation.
mrt fix(and its Django backup/restore scaffolding) was ~1100 lines doing something fundamentally outside the charter of a rollback-testing tool. It carried its own correctness risk (regex-based codegen) and coupled a separate lifecycle to the verifier's reputation. Dropping it sharpens the library's scope.What's removed
core/fixer.py,adapters/django_fixer.py,commands/fix.py— themrt fixcommandcommands/clean_backups.py—mrt clean-backupsonly cleaned the_mrt_backupstable thatmrt fix-generated migrations created; orphaned once fixer is gonefixablefield inmrt check --format jsonoutput (advertised a now-removed capability)test_fixer.py,test_django_fixer.py,test_django_fixer_e2e.py) and thedjango_fixer_apptest fixtureBreaking changes
mrt fixandmrt clean-backupscommands no longer existfixablepytest-mrt<1.5.0if you need auto-fix)Verification
ruff check+ruff format --checkcleanversion, check, drift, init, report, explainNote on base branch
Based on
test/coverage-completeness-gaps(PR #87) so the diff shows only the removal. Merge after #87 lands, or rebase ontomain.