feat!: remove auto-fix subsystem (mrt fix, clean-backups) — out of scope#89
Merged
Conversation
Migration code generation is a transform, not a verify operation, and does not belong in a rollback-testing tool. Removes ~1100 lines: - core/fixer.py, adapters/django_fixer.py, commands/fix.py (mrt fix) - commands/clean_backups.py (mrt clean-backups — only cleaned the _mrt_backups table that mrt fix-generated migrations created) - fixable field from mrt check --format json output - associated tests and the django_fixer_app test fixture - docs, roadmap, and contributing references BREAKING CHANGE: mrt fix and mrt clean-backups commands are gone, and the JSON findings no longer include a fixable field. Pin pytest-mrt<1.5.0 if you depend on auto-fix. Bumped to 1.5.0.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mrt fixcommand,core/fixer.py,adapters/django_fixer.py,commands/fix.py,commands/clean_backups.pytest_fixer.py,test_django_fixer.py,test_django_fixer_e2e.py)fixablefield from JSON output and related fixer referencescoverage run -m pytesttopytest --covfor accurate codecov reportingWhy
Auto-fixing migration files is "transform", not "verify" — outside the core scope of pytest-mrt.
The fixer added ~1100 lines of complexity with non-trivial risk (modifying production migration files).
pytest-mrt's goal: "data survives rollback", nothing more.
Breaking change
mrt fixcommand is removed. v1.5.0.