Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
python-version: "3.13"

- name: Install
run: pip install -e ".[dev,postgres]" coverage
run: pip install -e ".[dev,postgres]"

- name: Run PostgreSQL tests
env:
Expand Down Expand Up @@ -159,7 +159,7 @@ jobs:
python-version: "3.13"

- name: Install
run: pip install -e ".[dev,mysql]" coverage
run: pip install -e ".[dev,mysql]"

- name: Run MySQL tests
env:
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
python-version: "3.13"

- name: Install
run: pip install -e ".[dev,oracle]" coverage
run: pip install -e ".[dev,oracle]"

- name: Run Oracle tests
env:
Expand Down Expand Up @@ -290,7 +290,7 @@ jobs:
"

- name: Install
run: pip install -e ".[dev,mssql]" coverage
run: pip install -e ".[dev,mssql]"

- name: Run SQL Server tests
env:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Changelog = "https://github.com/croc100/pytest-mrt/releases"
[project.optional-dependencies]
dev = [
"pytest",
"pytest-cov",
"coverage",
"psycopg2-binary",
"hatch",
"ruff",
Expand Down
91 changes: 91 additions & 0 deletions tests/test_django_detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -608,3 +608,94 @@ class Migration(migrations.Migration):
warnings = analyze_django_migrations(str(tmp_path))
codes = [w.code for w in warnings]
assert "MRT601" not in codes, "Positional reverse_code must not trigger MRT601"


# --- --since / --min-revision (dependency-graph scoping) ---


def _chain(tmp_path):
"""Build a three-migration chain 0001 -> 0002 (drop) -> 0003 (drop)."""
django_migration(
tmp_path,
"0001_initial.py",
"""
from django.db import migrations

class Migration(migrations.Migration):
dependencies = []
operations = []
""",
)
django_migration(
tmp_path,
"0002_drop_phone.py",
"""
from django.db import migrations

class Migration(migrations.Migration):
dependencies = [('myapp', '0001_initial')]
operations = [
migrations.RemoveField(model_name='user', name='phone'),
]
""",
)
django_migration(
tmp_path,
"0003_drop_bio.py",
"""
from django.db import migrations

class Migration(migrations.Migration):
dependencies = [('myapp', '0002_drop_phone')]
operations = [
migrations.RemoveField(model_name='user', name='bio'),
]
""",
)


def test_since_includes_only_dependents(tmp_path):
"""--since scopes analysis to migrations that transitively depend on it."""
_chain(tmp_path)
# since 0002 -> only 0003 is a dependent; 0002's own drop is excluded.
warnings = analyze_django_migrations(str(tmp_path), since="myapp.0002_drop_phone")
names = {w.revision for w in warnings}
assert "myapp.0003_drop_bio" in names
assert "myapp.0002_drop_phone" not in names


def test_since_root_includes_all_dependents(tmp_path):
"""--since the root migration includes every later migration."""
_chain(tmp_path)
warnings = analyze_django_migrations(str(tmp_path), since="myapp.0001_initial")
names = {w.revision for w in warnings}
assert "myapp.0002_drop_phone" in names
assert "myapp.0003_drop_bio" in names


def test_since_unknown_revision_yields_nothing(tmp_path):
"""--since an unknown key selects no migrations."""
_chain(tmp_path)
warnings = analyze_django_migrations(str(tmp_path), since="myapp.9999_missing")
assert warnings == []


def test_min_revision_intersects_with_since(tmp_path):
"""--since and --min-revision are intersected."""
_chain(tmp_path)
# since 0001 -> {0002, 0003}; min_revision 0002 -> {0003}; intersection -> {0003}.
warnings = analyze_django_migrations(
str(tmp_path),
since="myapp.0001_initial",
min_revision="myapp.0002_drop_phone",
)
names = {w.revision for w in warnings}
assert names == {"myapp.0003_drop_bio"}


def test_min_revision_alone(tmp_path):
"""--min-revision alone scopes to its dependents."""
_chain(tmp_path)
warnings = analyze_django_migrations(str(tmp_path), min_revision="myapp.0002_drop_phone")
names = {w.revision for w in warnings}
assert names == {"myapp.0003_drop_bio"}