Skip to content

Commit 034df82

Browse files
authored
Fix 1892 (#1893)
* start new dev branch; add audit file * Fix #1892: ignore ty 0.0.53 possibly-missing-submodule + unused-type-ignore-comment ty is run unpinned (we ride the latest release and adjust the ignore list as it evolves). ty 0.0.53 began emitting two diagnostic classes on existing, unchanged source that the check-typing recipe did not ignore, so `ty check` exited 1 and Code Quality Checks went red: - 921x possibly-missing-submodule (vendored FlatBuffers-generated code under src/autobahn/wamp/gen/** plus a few flatbuffers.* re-export sites in message_fbs.py / message.py / protocol.py) - 1x unused-type-ignore-comment (src/autobahn/util.py:1062) 0 errors; all warnings. Drift, not a code regression: master was green on 2026-06-19 with an earlier ty, and went red on a 2026-06-25 run that pulled ty 0.0.53 (surfaced on the unrelated example-cleanup PR #1887). Add both rules to the check-typing --ignore list. Reproduced red->green locally with ty 0.0.53 against the cpy311 venv: 922 diagnostics/exit 1 before, "All checks passed!"/exit 0 after. Note: This work was completed with AI assistance (Claude Code).
1 parent 522e83b commit 034df82

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

.audit/oberstet_fix_1892.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
- [ ] I did **not** use any AI-assistance tools to help create this pull request.
2+
- [x] I **did** use AI-assistance tools to *help* create this pull request.
3+
- [x] I have read, understood and followed the projects' [AI Policy](https://github.com/crossbario/autobahn-python/blob/main/AI_POLICY.md) when creating code, documentation etc. for this pull request.
4+
5+
Submitted by: @oberstet
6+
Date: 2026-06-25
7+
Related issue(s): #1892
8+
Branch: oberstet:fix_1892

justfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -715,6 +715,8 @@ check-typing venv="": (install venv)
715715
--ignore no-matching-overload \
716716
--ignore conflicting-declarations \
717717
--ignore deprecated \
718+
--ignore possibly-missing-submodule \
719+
--ignore unused-type-ignore-comment \
718720
src/autobahn/
719721
720722
# pyright --project pyproject-static-typing.toml src/autobahn/wamp/request.py

0 commit comments

Comments
 (0)