fix: late init: don't omit non-empty pointers, even if a zero-value lies behind it

Author: Julian Wefers

pkg/resource/lateinit.go

@@ -134,8 +134,6 @@ func zeroValueJSONOmitEmptyFilter(cName string) ValueFilter {
 			return true
 		case (k == reflect.Slice || k == reflect.Map) && v.Len() == 0:
 			return true
-		case k == reflect.Ptr && v.Elem().IsZero():
-			return true
 		default:
 			return false
 		}

pkg/resource/lateinit_test.go

@@ -478,14 +478,25 @@ func TestLateInitialize(t *testing.T) {
 			wantModified: false,
 			wantCRObject: &nestedStruct4{},
 		},
-		"TestSkipOmitemptyTaggedPtrElem": {
+		"TestIncludeZeroValuePtrElem": {
 			args: args{
 				desiredObject: &nestedStruct4{},
 				observedObject: &nestedStruct4{
 					F1: &testStringEmpty,
 				},
 				opts: []GenericLateInitializerOption{WithZeroValueJSONOmitEmptyFilter(CNameWildcard)},
 			},
+			wantModified: true,
+			wantCRObject: &nestedStruct4{
+				F1: &testStringEmpty,
+			},
+		},
+		"TestSkipNilPtrElem": {
+			args: args{
+				desiredObject:  &nestedStruct4{},
+				observedObject: &nestedStruct4{},
+				opts:           []GenericLateInitializerOption{WithZeroValueJSONOmitEmptyFilter(CNameWildcard)},
+			},
 			wantModified: false,
 			wantCRObject: &nestedStruct4{},
 		},