add json encoded debug logging of diff detected instead of GoString to ensure readability#474
add json encoded debug logging of diff detected instead of GoString to ensure readability#474larhauga wants to merge 1 commit into
Conversation
mbbush
left a comment
There was a problem hiding this comment.
This would be a very welcome improvement. Thanks!
|
@larhauga can you update this PR based on the feedback on needing an else clause? |
…o ensure readability Signed-off-by: Lars Haugan <lars.haugan@sparebank1.no>
Sorry for the delay! Added the else clause now :) |
|
Are there any blockers to have this feature merged? Would be really useful to have when debugging issues related to upjet-based providers |
|
|
1 similar comment
|
|
Description of your changes
This change will provide debug logging in json format instead of go string. This will help when debugging why changes are not affected as this may be the only way you can figure out the different quirks of the cloud provider APIs.
This will remove type information from the output logs, but it will be parsable.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Printed out the new format during test run.