Skip to content

Commit 6539460

Browse files
authored
feat: Added branchId & directoryId param in list language translations (#225)
1 parent 9a4d5ad commit 6539460

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

src/main/java/com/crowdin/client/stringtranslations/StringTranslationsApi.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ public void removeApproval(Long projectId, Long approvalId) throws HttpException
113113
* @param stringIds filter translations by stringIds
114114
* @param labelIds filter translations by labelIds
115115
* @param fileId filter translations by file identifier
116+
* @param branchId filter translations by branchId
117+
* @param directoryId filter translations by directoryId
116118
* @param croql filter translations by croql
117119
* @param denormalizePlaceholders enable denormalize placeholders
118120
* @param limit maximum number of items to retrieve (default 25)
@@ -123,12 +125,14 @@ public void removeApproval(Long projectId, Long approvalId) throws HttpException
123125
* <li><a href="https://developer.crowdin.com/enterprise/api/v2/#operation/api.projects.languages.translations.getMany" target="_blank"><b>Enterprise API Documentation</b></a></li>
124126
* </ul>
125127
*/
126-
public ResponseList<LanguageTranslations> listLanguageTranslations(Long projectId, String languageId, String stringIds, String labelIds, Long fileId, String croql, Integer denormalizePlaceholders, Integer limit, Integer offset) throws HttpException, HttpBadRequestException {
128+
public ResponseList<LanguageTranslations> listLanguageTranslations(Long projectId, String languageId, String stringIds, String labelIds, Long fileId, Long branchId, Long directoryId, String croql, Integer denormalizePlaceholders, Integer limit, Integer offset) throws HttpException, HttpBadRequestException {
127129
String builtUrl = String.format("%s/projects/%d/languages/%s/translations", this.url, projectId, languageId);
128130
Map<String, Optional<Object>> queryParams = HttpRequestConfig.buildUrlParams(
129131
"stringIds", Optional.ofNullable(stringIds),
130132
"labelIds", Optional.ofNullable(labelIds),
131133
"fileId", Optional.ofNullable(fileId),
134+
"branchId", Optional.ofNullable(branchId),
135+
"directoryId", Optional.ofNullable(directoryId),
132136
"croql", Optional.ofNullable(croql),
133137
"denormalizePlaceholders", Optional.ofNullable(denormalizePlaceholders),
134138
"limit", Optional.ofNullable(limit),

src/test/java/com/crowdin/client/stringtranslations/StringTranslationsApiTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,23 +93,23 @@ public void removeApprovalTest() {
9393

9494
@Test
9595
public void listLanguageTranslationsPlainTest() {
96-
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(projectId, language, null, null, null, null, null, null, null);
96+
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(projectId, language, null, null, null, null, null, null, null, null, null);
9797
assertEquals(1, languageTranslationsList.getData().size());
9898
assertTrue(languageTranslationsList.getData().get(0).getData() instanceof PlainLanguageTranslations, "Wrong return type, must be PlainLanguageTranslations");
9999
assertEquals(stringId, ((PlainLanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId());
100100
}
101101

102102
@Test
103103
public void listLanguageTranslationsPluralTest() {
104-
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(secondProjectId, language, null, null, null, null, null, null, null);
104+
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(secondProjectId, language, null, null, null, null, null, null, null, null, null);
105105
assertEquals(1, languageTranslationsList.getData().size());
106106
assertTrue(languageTranslationsList.getData().get(0).getData() instanceof PluralLanguageTranslations, "Wrong return type, must be PluralLanguageTranslations");
107107
assertEquals(stringId, ((PluralLanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId());
108108
}
109109

110110
@Test
111111
public void listLanguageTranslationsICUTest() {
112-
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(thirdProjectId, language, null, null, null, null, null, null, null);
112+
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(thirdProjectId, language, null, null, null, null, null, null, null, null, null);
113113
assertEquals(1, languageTranslationsList.getData().size());
114114
assertTrue(languageTranslationsList.getData().get(0).getData() instanceof ICULanguageTranslations, "Wrong return type, must be ICULanguageTranslations");
115115
assertEquals(stringId, ((ICULanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId());

0 commit comments

Comments
 (0)