Skip to content

Commit 6e769d2

Browse files
committed
Incorporated suggested changes!
1 parent 3584d14 commit 6e769d2

3 files changed

Lines changed: 20 additions & 12 deletions

File tree

src/main/java/com/crowdin/client/translations/TranslationsApi.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,12 +292,17 @@ public ResponseObject<PreTranslation> editPreTranslation(Long projectId, String
292292
}
293293

294294
/**
295-
* Get Pre-Translation Report
296-
*
297-
* @param projectId project identifier
298-
* @param preTranslationId Pre-translation identifier
295+
* Pre-Translation Report
296+
*
297+
* @param projectId project identifier
298+
* @param preTranslationId pre-translation identifier
299+
* @return pre-translation report data
300+
* @see <ul>
301+
* <li><a href="https://developer.crowdin.com/api/v2/#tag/Translations/operation/api.projects.pre-translations.report.getReport" target="_blank"><b>API Documentation</b></a></li>
302+
* <li><a href="https://developer.crowdin.com/enterprise/api/v2/#tag/Translations/operation/api.projects.pre-translations.report.getReport" target="_blank"><b>Enterprise API Documentation</b></a></li>
303+
* </ul>
299304
*/
300-
public ResponseObject<PreTranslationReportResponse> getPreTranslationReport(Long projectId, String preTranslationId) throws HttpException , HttpBadRequestException{
305+
public ResponseObject<PreTranslationReportResponse> getPreTranslationReport(Long projectId, String preTranslationId) throws HttpException, HttpBadRequestException {
301306
PreTranslationReportResponseObject response = this.httpClient.get(
302307
this.url + "/projects/" + projectId + "/pre-translations/" + preTranslationId + "/report",
303308
new HttpRequestConfig(),

src/main/java/com/crowdin/client/translations/model/PreTranslationReportResponse.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,21 @@
33
import lombok.Data;
44
import java.util.List;
55
import java.util.Map;
6+
import com.crowdin.client.translationstatus.model.Category;
7+
8+
69
@Data
710
public class PreTranslationReportResponse {
811

9-
private List<Language> languages;
10-
private String preTranslateType;
12+
private List<TargetLanguage> languages;
13+
private Method preTranslateType;
1114

1215
@Data
13-
public static class Language {
16+
public static class TargetLanguage {
1417
private String id;
1518
private List<File> files;
1619
private Map<String, Integer> skipped;
17-
private List<String> skippedQaCheckCategories;
20+
private List<Category> skippedQaCheckCategories;
1821
}
1922

2023
@Data

src/test/java/com/crowdin/client/translations/TranslationsApiTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public List<RequestMock> getMocks() {
7272
RequestMock.build(String.format("%s/projects/%d/translations/exports", this.url, projectId), HttpPost.METHOD_NAME, "api/translations/exportProjectTranslationRequest.json", "api/translations/exportProjectTranslationResponse.json"),
7373
RequestMock.build(this.url + "/projects/" + projectId + "/pre-translations", HttpGet.METHOD_NAME, "api/translations/listPreTranslations.json"),
7474
RequestMock.build(this.url + "/projects/" + projectId + "/pre-translations/" + preTranslationId, HttpPatch.METHOD_NAME, "api/translations/editPreTranslationRequest.json", "api/translations/editPreTranslationResponse.json"),
75-
RequestMock.build(this.url + "/projects/" + projectId + "/pre-translations/" + preTranslationId + "/report",HttpGet.METHOD_NAME,"api/translations/preTranslationReportResponse.json")
75+
RequestMock.build(this.url + "/projects/" + projectId + "/pre-translations/" + preTranslationId + "/report", HttpGet.METHOD_NAME, "api/translations/preTranslationReportResponse.json")
7676
);
7777
}
7878

@@ -275,8 +275,8 @@ public void getPreTranslationReportTest() {
275275
ResponseObject<PreTranslationReportResponse> response = this.getTranslationsApi().getPreTranslationReport(projectId, preTranslationId);
276276
PreTranslationReportResponse report = response.getData();
277277
assertNotNull(report);
278-
assertEquals("ai", report.getPreTranslateType());
279-
PreTranslationReportResponse.Language lang = report.getLanguages().get(0);
278+
assertEquals(Method.AI, report.getPreTranslateType());
279+
PreTranslationReportResponse.TargetLanguage lang = report.getLanguages().get(0);
280280
assertEquals(language, lang.getId());
281281
PreTranslationReportResponse.File file = lang.getFiles().get(0);
282282
assertEquals(fileId, file.getId());

0 commit comments

Comments
 (0)