Skip to content

feat: support for new group managers and teams features#582

Merged
andrii-bodnar merged 5 commits into
crowdin:masterfrom
Ribas160:group_managers_teams_features
Oct 30, 2025
Merged

feat: support for new group managers and teams features#582
andrii-bodnar merged 5 commits into
crowdin:masterfrom
Ribas160:group_managers_teams_features

Conversation

@Ribas160

Copy link
Copy Markdown
Contributor

Resolves #468

@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.89%. Comparing base (59981f1) to head (52bc230).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/users/index.ts 72.73% 0 Missing and 3 partials ⚠️
src/teams/index.ts 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   90.04%   89.89%   -0.14%     
==========================================
  Files          40       40              
  Lines        1996     2017      +21     
  Branches      208      213       +5     
==========================================
+ Hits         1797     1813      +16     
  Misses         82       82              
- Partials      117      122       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrii-bodnar andrii-bodnar requested a review from Copilot October 29, 2025 14:33
@andrii-bodnar andrii-bodnar changed the title feat: support for new group managers and teams features (#468) feat: support for new group managers and teams features Oct 29, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for managing group managers and group teams in the Crowdin Enterprise API. It introduces three new API methods for each resource: listing, updating via PATCH operations, and retrieving individual items.

  • Added methods to list, update, and get group managers in the Users API
  • Added methods to list, update, and get group teams in the Teams API
  • Added comprehensive test coverage for all new methods

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/users/index.ts Added listGroupManagers, updateGroupManagers, and getGroupManager methods with corresponding TypeScript interfaces
src/teams/index.ts Added listGroupTeams, updateGroupTeams, and getGroupTeam methods with corresponding TypeScript interfaces
tests/users/api.test.ts Added test cases for group manager operations with nock mocks
tests/teams/api.test.ts Added test cases for group team operations with nock mocks
Comments suppressed due to low confidence (1)

tests/teams/api.test.ts:4

  • The describe block is named 'Tasks API' but this test file is for the Teams API. It should be 'Teams API' to accurately reflect what is being tested.
describe('Tasks API', () => {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/users/index.ts Outdated
Comment thread src/users/index.ts Outdated
Comment thread src/teams/index.ts Outdated
Comment thread src/teams/index.ts Outdated
Ribas160 and others added 4 commits October 30, 2025 09:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment thread tests/users/api.test.ts

@andrii-bodnar andrii-bodnar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ribas160 thank you!

@andrii-bodnar andrii-bodnar merged commit 3da8da4 into crowdin:master Oct 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for new group managers and teams features

3 participants