Skip to content

feat(bundles): add export settings to export bundle#680

Merged
andrii-bodnar merged 3 commits into
crowdin:masterfrom
hardattmangrola:feature/export-bundle-request-body
Jun 10, 2026
Merged

feat(bundles): add export settings to export bundle#680
andrii-bodnar merged 3 commits into
crowdin:masterfrom
hardattmangrola:feature/export-bundle-request-body

Conversation

@hardattmangrola

Copy link
Copy Markdown
Contributor

Changes

  • Added ExportBundleRequest interface
  • Added request body support for Export Bundle endpoint
  • Added export settings to bundle export response attributes
  • Made startedAt and finishedAt nullable
  • Updated Check Bundle Export Status response types
  • Added tests

Fixes #678

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Bundles API client to support the new Export Bundle request body options and to surface the newly returned export settings in export status responses, aligning the SDK with the Crowdin API changes described in issue #678.

Changes:

  • Adds ExportBundleRequest and sends it as the POST body for exportBundle.
  • Extends bundle export status typings to include export settings under attributes, and makes startedAt/finishedAt nullable.
  • Updates tests to cover request-body export and the enriched/nullable export status response.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/bundles/api.test.ts Updates mocks/assertions to cover request-body export and new response attributes/nullability.
src/bundles/index.ts Adds request type, updates exportBundle signature/body, and updates export status/attributes types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/bundles/index.ts
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (d2fd74d) to head (7d58834).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          41       41           
  Lines        2189     2189           
  Branches      256      256           
=======================================
  Hits         1973     1973           
  Misses         82       82           
  Partials      134      134           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment thread src/bundles/index.ts Outdated

@andrii-bodnar andrii-bodnar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardattmangrola thank you!

@andrii-bodnar andrii-bodnar merged commit 1f277bc into crowdin:master Jun 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add request body and export settings to Export Bundle

3 participants