lint: usetesting - prefer test methods to handle temporary files

Author: mmetc

.golangci.yml

@@ -504,7 +504,7 @@ linters:
       constant-kind: true
 
     usetesting:
-      os-temp-dir: false
+      os-temp-dir: true
       context-background: true
       context-todo: true
 
@@ -627,16 +627,6 @@ linters:
         path: pkg/(appsec|acquisition|dumps|alertcontext|leakybucket|exprhelpers)
         text: 'rangeValCopy: .*'
 
-      - linters:
-          - usetesting
-        path: pkg/apiserver/(.+)_test.go
-        text: os.MkdirTemp.* could be replaced by t.TempDir.*
-
-      - linters:
-          - usetesting
-        path: pkg/apiserver/(.+)_test.go
-        text: os.CreateTemp.* could be replaced by os.CreateTemp.*
-
       - linters:
           - containedctx
         path: cmd/notification-file/main.go

pkg/acquisition/modules/appsec/appsec_rules_test.go

@@ -3,7 +3,6 @@ package appsecacquisition
 import (
 	"net/http"
 	"net/url"
-	"os"
 	"path/filepath"
 	"testing"
 
@@ -384,7 +383,7 @@ toto
 				require.True(t, responses[0].InBandInterrupt)
 
 				// Might fail if you have artifacts from previous tests, but good enough 99% of the time
-				tmpFiles, err := filepath.Glob(filepath.Join(os.TempDir(), "crzmp*"))
+				tmpFiles, err := filepath.Glob(filepath.Join(t.TempDir(), "crzmp*"))
 				require.NoError(t, err)
 				require.Empty(t, tmpFiles)
 			},

pkg/apiserver/apic_test.go

@@ -38,7 +38,7 @@ import (
 func getDBClient(t *testing.T, ctx context.Context) *database.Client {
 	t.Helper()
 
-	dbPath, err := os.CreateTemp("", "*sqlite")
+	dbPath, err := os.CreateTemp(t.TempDir(), "*sqlite")
 	require.NoError(t, err)
 	dbClient, err := database.NewClient(ctx, &csconfig.DatabaseCfg{
 		Type:   "sqlite",

pkg/apiserver/apiserver_test.go

@@ -54,13 +54,9 @@ func LoadTestConfig(t *testing.T) csconfig.Config {
 		MaxAge: maxAge,
 	}
 
-	tempDir, _ := os.MkdirTemp("", "crowdsec_tests")
-
-	t.Cleanup(func() { os.RemoveAll(tempDir) })
-
 	dbconfig := csconfig.DatabaseCfg{
 		Type:   "sqlite",
-		DbPath: filepath.Join(tempDir, "ent"),
+		DbPath: filepath.Join(t.TempDir(), "ent"),
 		Flush:  &flushConfig,
 	}
 	apiServerConfig := csconfig.LocalApiServerCfg{
@@ -104,13 +100,9 @@ func LoadTestConfigForwardedFor(t *testing.T) csconfig.Config {
 		MaxAge: maxAge,
 	}
 
-	tempDir, _ := os.MkdirTemp("", "crowdsec_tests")
-
-	t.Cleanup(func() { os.RemoveAll(tempDir) })
-
 	dbconfig := csconfig.DatabaseCfg{
 		Type:   "sqlite",
-		DbPath: filepath.Join(tempDir, "ent"),
+		DbPath: filepath.Join(t.TempDir(), "ent"),
 		Flush:  &flushConfig,
 	}
 	apiServerConfig := csconfig.LocalApiServerCfg{