Fix buffer size check

crskycode · crskycode · commit 3af2f480c0b9 · 2025-09-28T03:19:24.000+08:00
diff --git a/Common/stringhelper.cpp b/Common/stringhelper.cpp
@@ -229,7 +229,7 @@ namespace StringHelper
 			return std::wstring();
 		}
 
-		if (count < sizeof(buf))
+		if (count < _countof(buf))
 		{
 			// All characters have been written to the small buffer.
 			return std::wstring(buf, count);
@@ -267,7 +267,7 @@ namespace StringHelper
 			return std::wstring();
 		}
 
-		if (count < sizeof(buf))
+		if (count < _countof(buf))
 		{
 			// All characters have been written to the small buffer.
 			return std::wstring(buf, count);

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ namespace StringHelper`
`229`	`229`	`return std::wstring();`
`230`	`230`	`}`
`231`	`231`
`232`		`- if (count < sizeof(buf))`
	`232`	`+ if (count < _countof(buf))`
`233`	`233`	`{`
`234`	`234`	`// All characters have been written to the small buffer.`
`235`	`235`	`return std::wstring(buf, count);`
`@@ -267,7 +267,7 @@ namespace StringHelper`
`267`	`267`	`return std::wstring();`
`268`	`268`	`}`
`269`	`269`
`270`		`- if (count < sizeof(buf))`
	`270`	`+ if (count < _countof(buf))`
`271`	`271`	`{`
`272`	`272`	`// All characters have been written to the small buffer.`
`273`	`273`	`return std::wstring(buf, count);`