wip

Author: sgtoj

docs/github-app-setup.md

@@ -25,8 +25,8 @@ This guide walks through creating and installing a GitHub App for github-ops-app
    | Webhook > Active      | **Uncheck** to disable webhooks initially       |
 
    > **Note**: Disable webhooks during creation since you may not know your
-   > endpoint URL until after deployment. You'll configure and enable webhooks
-   > in [Step 10](#step-10-configure-webhook).
+   > endpoint URL until after deployment. You'll configure webhooks and
+   > subscribe to events in [Step 7](#step-7-configure-webhook-and-events).
 
 ### Configure Permissions
 
@@ -46,23 +46,15 @@ Under **Permissions**, set the following:
 | Members        | Read/Write | Manage team membership           |
 | Administration | Read       | Read organization settings       |
 
-## Step 2: Subscribe to Events
+4. Set installation scope:
 
-Under **Subscribe to events**, check:
+   | Setting                                 | Value                |
+   |-----------------------------------------|----------------------|
+   | Where can this GitHub App be installed? | Only on this account |
 
-- [x] **Pull request** - PR open, close, merge events
-- [x] **Team** - Team creation, deletion, changes
-- [x] **Membership** - Team membership changes
+5. Click **Create GitHub App**
 
-## Step 3: Installation Settings
-
-| Setting                                 | Value                |
-|-----------------------------------------|----------------------|
-| Where can this GitHub App be installed? | Only on this account |
-
-Click **Create GitHub App**.
-
-## Step 4: Generate Private Key
+## Step 2: Generate Private Key
 
 After creating the app:
 
@@ -72,13 +64,13 @@ After creating the app:
 4. This file is used for `APP_GITHUB_APP_PRIVATE_KEY` or
    `APP_GITHUB_APP_PRIVATE_KEY_PATH`
 
-## Step 5: Note Your App ID
+## Step 3: Note Your App ID
 
 On the app's settings page, find and save:
 
 - **App ID** - numeric ID displayed near the top (e.g., `123456`)
 
-## Step 6: Install the App
+## Step 4: Install the App
 
 1. In the left sidebar, click **Install App**
 2. Select your organization
@@ -87,7 +79,7 @@ On the app's settings page, find and save:
    - **Only select repositories** - if limiting scope
 4. Click **Install**
 
-## Step 7: Get Installation ID
+## Step 5: Get Installation ID
 
 After installation, you'll be redirected to a URL like:
 ```
@@ -103,7 +95,7 @@ curl -H "Authorization: Bearer YOUR_JWT" \
   https://api.github.com/app/installations
 ```
 
-## Step 8: Configure Environment Variables
+## Step 6: Configure Environment Variables
 
 Set these environment variables in your deployment:
 
@@ -126,7 +118,7 @@ APP_GITHUB_APP_PRIVATE_KEY_PATH=/path/to/private-key.pem
 APP_GITHUB_APP_PRIVATE_KEY=arn:aws:ssm:us-east-1:123456789:parameter/github-bot/private-key
 ```
 
-## Step 9: Configure Webhook
+## Step 7: Configure Webhook and Events
 
 After deploying your server, configure and enable webhooks:
 
@@ -138,6 +130,13 @@ After deploying your server, configure and enable webhooks:
 3. Check **Active** to enable webhooks
 4. Click **Save changes**
 
+5. Under **Subscribe to events**, check:
+   - [x] **Pull request** - PR open, close, merge events
+   - [x] **Team** - Team creation, deletion, changes
+   - [x] **Membership** - Team membership changes
+
+6. Click **Save changes**
+
 ## Using the App Manifest (Alternative)
 
 For automated setup, use the manifest at `assets/github/manifest.json`: