Skip to content

reproduction: e2e test for bug #990 #1022

Open
salmin89 wants to merge 5 commits into
crxjs:mainfrom
salmin89:bug/990--added-e2e-test
Open

reproduction: e2e test for bug #990 #1022
salmin89 wants to merge 5 commits into
crxjs:mainfrom
salmin89:bug/990--added-e2e-test

Conversation

@salmin89
Copy link
Copy Markdown
Contributor

I didn't fully know how to test if there are plugin errors or not, but this test will error following this issue:
#990

run:

pnpm --filter vite-plugin test:e2e packages/vite-plugin/tests/e2e/mv3-vite-dynamic-content-script-build-watch/vite-build-watch.test.ts

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 13, 2025

⚠️ No Changeset found

Latest commit: cd54118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vite-plugin-docs ❌ Failed (Inspect) Jun 20, 2025 8:13pm

@Toumash
Copy link
Copy Markdown
Member

Toumash commented Jun 13, 2025

Thank you for your contribution @salmin89!
We'll take a look

ci tests currently fails because of other reason lets ignore it for a moment.

@Toumash Toumash changed the title Bug/990 added e2e test reproduction: e2e test for bug #990 Jun 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for contributing to CRXJS! This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days.

@github-actions github-actions Bot added the Stale label Sep 19, 2025
@Toumash Toumash added not-stale and removed Stale labels Sep 19, 2025
@Toumash
Copy link
Copy Markdown
Member

Toumash commented Jan 15, 2026

hmmm does it need more fixes for the e2e? we'll find out after merging master to it

@salmin89
Copy link
Copy Markdown
Contributor Author

hmmm does it need more fixes for the e2e? we'll find out after merging master to it

I don't think there has been a fix for #990
I added this e2e to replicate the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants