fix(vite-plugin): move @rollup/pluginutils to devDependencies#1164
Open
Toumash wants to merge 2 commits into
Open
fix(vite-plugin): move @rollup/pluginutils to devDependencies#1164Toumash wants to merge 2 commits into
Toumash wants to merge 2 commits into
Conversation
It is only used in tests/jest.globalSetup.ts for normalizePath, which is already handled by pathe (an existing runtime dep). Replaced the two normalizePath() calls with direct pathe usage.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rollup/pluginutilswas listed as a runtimedependencybut is only used intests/jest.globalSetup.tsfornormalizePathpathe(already a runtime dependency) provides equivalent path normalization natively, so the twonormalizePath()calls were replaced with directpath.join()/ plain array usage@rollup/pluginutilstodevDependencieswhere it belongsTesting
All 131 tests pass (57 out + 48 e2e test files, 4 pre-existing skips).