format byte sizes more nicely in labels

Author: andrewazores

src/openshift/actions/DeploymentLabelAction/DeploymentLabelActionModal.tsx

@@ -51,6 +51,7 @@ import {
   LogLevel,
   parseDuration,
   formatDurationForLabel,
+  formatByteSizeForLabel,
   AGENT_LABEL_KEYS,
 } from './utils';
 
@@ -313,7 +314,7 @@ export const DeploymentLabelActionModal: React.FC<CryostatModalProps> = ({ kind,
       {
         op: 'replace',
         path: `/spec/template/metadata/labels/${AGENT_LABEL_KEYS.HARVESTER_EXIT_MAX_SIZE.replace('/', '~1')}`,
-        value: formData.harvesterExitMaxSizeB.toString(),
+        value: formatByteSizeForLabel(formData.harvesterExitMaxSizeB),
       },
     ];
 
@@ -497,7 +498,7 @@ export const DeploymentLabelActionModal: React.FC<CryostatModalProps> = ({ kind,
           {
             op: 'replace',
             path: `/spec/template/metadata/labels/${AGENT_LABEL_KEYS.HARVESTER_EXIT_MAX_SIZE.replace('/', '~1')}`,
-            value: quickRegisterData.harvesterExitMaxSizeB.toString(),
+            value: formatByteSizeForLabel(quickRegisterData.harvesterExitMaxSizeB),
           },
         ];
         if (cryostatInstance.metadata?.labels?.[AGENT_LABEL_KEYS.LOG_LEVEL]) {

src/openshift/actions/DeploymentLabelAction/utils.ts

@@ -98,6 +98,25 @@ export function formatDurationForLabel(durationMs: number): string {
   return `${durationMs}ms`;
 }
 
+export function formatByteSizeForLabel(bytes: number): string {
+  const gi = bytes / (1024 * 1024 * 1024);
+  if (Number.isInteger(gi) && gi >= 1) {
+    return `${gi}Gi`;
+  }
+
+  const mi = bytes / (1024 * 1024);
+  if (Number.isInteger(mi) && mi >= 1) {
+    return `${mi}Mi`;
+  }
+
+  const ki = bytes / 1024;
+  if (Number.isInteger(ki) && ki >= 1) {
+    return `${ki}Ki`;
+  }
+
+  return `${bytes}`;
+}
+
 export function getAgentConfig(container: Container): AgentConfig | null {
   const labels = container.labels;
   if (!labels) {