feat(autoconfig): wizard supports callback-port, harvester-template, harvester-max-files labels#886
Open
andrewazores wants to merge 6 commits intocryostatio:mainfrom
Open
feat(autoconfig): wizard supports callback-port, harvester-template, harvester-max-files labels#886andrewazores wants to merge 6 commits intocryostatio:mainfrom
andrewazores wants to merge 6 commits intocryostatio:mainfrom
Conversation
81acae7 to
3a866e0
Compare
3a866e0 to
d4c0fd7
Compare
jtolentino1
reviewed
Apr 24, 2026
| harvesterPeriodMs: parseDuration(harvesterPeriod, 900000), | ||
| harvesterMaxFiles: harvesterMaxFiles ? parseInt(harvesterMaxFiles, 10) : 4, | ||
| harvesterExitMaxAgeMs: parseDuration(harvesterExitMaxAge, 300000), | ||
| harvesterExitMaxSizeB: harvesterExitMaxSize ? parseInt(harvesterExitMaxSize, 10) : 20971520, |
Member
There was a problem hiding this comment.
Should this parse Kubernetes quantity suffixes instead of using parseInt? The wizard writes this label with formatByteSizeForLabel(), so values like 20Mi can be saved. When the modal opens again, parseInt('20Mi', 10) becomes 20, so the wizard treats it as 20 bytes instead of 20 MiB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainDepends on #833
Based on #833
Depends on cryostatio/cryostat-operator#1277
Description of the change:
cryostat.io/namespace,cryostat.io/name,cryostat.io/harvester-template) instead of using both pod labels and environment variables