Skip to content

feat(autoconfig): wizard supports callback-port, harvester-template, harvester-max-files labels#886

Open
andrewazores wants to merge 6 commits intocryostatio:mainfrom
andrewazores:wizard-more-labels
Open

feat(autoconfig): wizard supports callback-port, harvester-template, harvester-max-files labels#886
andrewazores wants to merge 6 commits intocryostatio:mainfrom
andrewazores:wizard-more-labels

Conversation

@andrewazores
Copy link
Copy Markdown
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Depends on #833
Based on #833
Depends on cryostatio/cryostat-operator#1277

Description of the change:

  1. Refactors the deployment action to rely only on the Cryostat Operator pod labels (ie cryostat.io/namespace, cryostat.io/name, cryostat.io/harvester-template) instead of using both pod labels and environment variables
  2. Adds support for harvester periodic push period, harvester periodic push max files, and Agent HTTP callback port

@andrewazores andrewazores added feat New feature or request safe-to-test labels Apr 16, 2026
@github-actions github-actions Bot added the needs-triage Needs thorough attention from code reviewers label Apr 16, 2026
@mergify mergify Bot requested a review from a team April 16, 2026 21:35
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Apr 16, 2026
@andrewazores andrewazores marked this pull request as ready for review April 17, 2026 13:45
@andrewazores andrewazores requested a review from a team as a code owner April 17, 2026 13:45
@andrewazores andrewazores removed the request for review from a team April 20, 2026 17:10
Copy link
Copy Markdown
Member

@jtolentino1 jtolentino1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on an OpenShift cluster with Cryostat Operator installed. Applied the wizard-style labels to a Deployment and verified the Operator injected the Agent with callback port + harvester period/max-files settings.

Just one minor comment below

harvesterPeriodMs: parseDuration(harvesterPeriod, 900000),
harvesterMaxFiles: harvesterMaxFiles ? parseInt(harvesterMaxFiles, 10) : 4,
harvesterExitMaxAgeMs: parseDuration(harvesterExitMaxAge, 300000),
harvesterExitMaxSizeB: harvesterExitMaxSize ? parseInt(harvesterExitMaxSize, 10) : 20971520,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this parse Kubernetes quantity suffixes instead of using parseInt? The wizard writes this label with formatByteSizeForLabel(), so values like 20Mi can be saved. When the modal opens again, parseInt('20Mi', 10) becomes 20, so the wizard treats it as 20 bytes instead of 20 MiB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants