Skip to content

chore(yarn): align dependencies with Console#895

Merged
andrewazores merged 15 commits into
cryostatio:mainfrom
andrewazores:dependency-alignment
Apr 28, 2026
Merged

chore(yarn): align dependencies with Console#895
andrewazores merged 15 commits into
cryostatio:mainfrom
andrewazores:dependency-alignment

Conversation

@andrewazores

@andrewazores andrewazores commented Apr 20, 2026

Copy link
Copy Markdown
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #894
Based on #846
Depends on #846
Depends on cryostatio/cryostat-web#2211
Depends on cryostatio/cryostat-web#2222

  1. Sets src/cryostat-web git submodule as a Yarn workspace
  2. Deduplicates the plugin's own package.json to remove dependencies which are really use by cryostat-web and not by the plugin itself
  3. Downgrades a few versions to match what's provided by the target OpenShift Console version

@andrewazores andrewazores added dependencies Pull requests that update a dependency file fix safe-to-test labels Apr 20, 2026
@github-actions github-actions Bot added the needs-triage Needs thorough attention from code reviewers label Apr 20, 2026
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Apr 20, 2026
@mergify mergify Bot requested a review from a team April 20, 2026 18:14
@andrewazores andrewazores requested review from a team and removed request for a team April 20, 2026 18:20
@mergify mergify Bot requested a review from a team April 20, 2026 18:21
@andrewazores andrewazores force-pushed the dependency-alignment branch 3 times, most recently from 1431dea to a315b57 Compare April 27, 2026 16:43
@andrewazores andrewazores removed the request for review from a team April 27, 2026 16:44
@andrewazores andrewazores force-pushed the dependency-alignment branch from a315b57 to ebfe895 Compare April 27, 2026 17:46
@andrewazores andrewazores force-pushed the dependency-alignment branch from b47be2a to 31f344f Compare April 27, 2026 18:08
@mergify mergify Bot requested a review from a team April 27, 2026 19:06
ebaron
ebaron previously approved these changes Apr 28, 2026
@mergify mergify Bot requested a review from a team April 28, 2026 16:10
@aptmac

aptmac commented Apr 28, 2026

Copy link
Copy Markdown
Member

Content looks good! Although there's some issues at the moment.

I opened a PR to update the Cypress tests as they might be useful here to just check that everything opens as expected: #909

@andrewazores

andrewazores commented Apr 28, 2026

Copy link
Copy Markdown
Member Author

Thanks @aptmac , the CI failures were because the cryostatio/cryostat-web#2222 changes weren't included. I've added the submodule update in here now (again) and it looks like it should pass this time.

@andrewazores andrewazores merged commit 6f4b7b0 into cryostatio:main Apr 28, 2026
10 checks passed
@andrewazores andrewazores deleted the dependency-alignment branch April 28, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file fix safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Plugin dependency alignment with Console

3 participants