Skip to content

feat(console-plugin): uninstall plugin when upgrading Cryostat on unsupported OCP version#1275

Merged
andrewazores merged 9 commits into
cryostatio:mainfrom
andrewazores:uninstall-console-plugin
Apr 15, 2026
Merged

feat(console-plugin): uninstall plugin when upgrading Cryostat on unsupported OCP version#1275
andrewazores merged 9 commits into
cryostatio:mainfrom
andrewazores:uninstall-console-plugin

Conversation

@andrewazores
Copy link
Copy Markdown
Member

@andrewazores andrewazores commented Apr 14, 2026

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #1259

Description of the change:

  1. Enhances the OpenShift Console Plugin installation check to additionally check if the current cluster version is below the minimum supported version. Previously the logic was a simple one-way "if version >= minimum, install plugin." Now there is an "else, uninstall plugin" branch. This covers the case where Cryostat/cryostat-web/cryostat-openshift-console-plugin are upgraded in a way that increases the required Console version compared to the previous Cryostat version. If a Cryostat installation on a given OpenShift cluster is upgraded and the cluster itself is not upgraded, then it's possible that some features will no longer be available and should be disabled/removed.
  2. Sets the minimum OpenShift version to 4.19 - see https://github.com/openshift/console/blob/main/frontend/packages/console-dynamic-plugin-sdk/README.md#patternfly, chore(patternfly): upgrade to Patternfly 6 cryostat-web#2137, chore(deps): update patternfly (major) cryostat-openshift-console-plugin#833, [Task] Investigate what PF stylesheets are provided by each version of the Console cryostat-openshift-console-plugin#128, and CONSOLE-5100: Remove support for PatternFly 5 openshift/console#16056
  3. Refactors the OpenShift version value from a hardcoded constant in the source code to an environment variable which can be set at build time. This helps consolidate all the versions to be updated into the Makefile.
  4. According to https://access.redhat.com/product-life-cycles?product=OpenShift%20Container%20Platform%204 , OpenShift 4.19 is currently in Maintenance support. 4.20 and 4.21 are the current fully supported versions but 4.22, the first version which will ship exclusively supporting Patternfly 6, will be coming soon.

How to manually test:

  1. Insert steps here...
  2. ...

@andrewazores andrewazores added feat New feature or request safe-to-test labels Apr 14, 2026
@github-actions github-actions Bot added the needs-triage Needs thorough attention from code reviewers label Apr 14, 2026
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Apr 14, 2026
@andrewazores andrewazores marked this pull request as draft April 14, 2026 13:55
@andrewazores andrewazores changed the title feat(console-plugin): uninstall plugin when upgrading Cryostat on unsupported OCP version" feat(console-plugin): uninstall plugin when upgrading Cryostat on unsupported OCP version Apr 14, 2026
@andrewazores andrewazores marked this pull request as ready for review April 15, 2026 13:24
@andrewazores andrewazores requested review from a team and ebaron April 15, 2026 13:24
@andrewazores andrewazores force-pushed the uninstall-console-plugin branch from 884a9f9 to 4e39558 Compare April 15, 2026 20:48
@andrewazores
Copy link
Copy Markdown
Member Author

/build_test

@github-actions
Copy link
Copy Markdown

/build_test completed successfully ✅.
View Actions Run.

@andrewazores andrewazores merged commit 6c56a86 into cryostatio:main Apr 15, 2026
8 checks passed
@andrewazores andrewazores deleted the uninstall-console-plugin branch April 15, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request] Uninstall Console Plugin artifacts if they exist on incompatible OCP version

2 participants