Review tweaks

Author: Vinsho

blockapi/v2/api/debank.py

@@ -627,9 +627,6 @@ def _parse_app(self, raw_app: dict) -> Optional[DebankApp]:
         predictions = []
 
         chain = DEBANK_APP_CHAIN_MAP.get(model.id)
-        if not chain:
-            logger.warning(f'Unknown chain for app {model.id}, using default')
-            chain = Blockchain.ETHEREUM
 
         for portfolio_item in model.portfolio_item_list:
             detail_types = portfolio_item.detail_types
@@ -655,7 +652,7 @@ def _parse_app(self, raw_app: dict) -> Optional[DebankApp]:
         )
 
     def _parse_prediction(
-        self, item: DebankModelAppPortfolioItem, chain: Blockchain
+        self, item: DebankModelAppPortfolioItem, chain: Optional[Blockchain]
     ) -> Optional[DebankPrediction]:
         """Parse a prediction market position."""
         try:
@@ -679,7 +676,7 @@ def _parse_prediction(
         )
 
     def _parse_deposit(
-        self, item: DebankModelAppPortfolioItem, chain: Blockchain
+        self, item: DebankModelAppPortfolioItem, chain: Optional[Blockchain]
     ) -> Optional[DebankAppDeposit]:
         """Parse a deposit/common type portfolio item."""
         return DebankAppDeposit.from_api(

blockapi/v2/models.py

@@ -1246,7 +1246,7 @@ class DebankPrediction:
     claimable: bool
     event_end_at: Optional[datetime]
     is_market_closed: bool
-    chain: Blockchain
+    chain: Optional[Blockchain]
     position_index: Optional[str]
     update_at: Optional[datetime]
 
@@ -1261,7 +1261,7 @@ def from_api(
         usd_value: Union[str, float, int],
         claimable: bool,
         is_market_closed: bool,
-        chain: Blockchain,
+        chain: Optional[Blockchain] = None,
         event_end_at: Optional[Union[int, float]] = None,
         position_index: Optional[str] = None,
         update_at: Optional[Union[int, float]] = None,
@@ -1290,7 +1290,7 @@ class DebankAppDeposit:
     debt_usd_value: Decimal
     net_usd_value: Decimal
     tokens: list[DebankDepositToken]
-    chain: Blockchain
+    chain: Optional[Blockchain]
     position_index: Optional[str]
     update_at: Optional[datetime]
 
@@ -1304,7 +1304,7 @@ def from_api(
         net_usd_value: Union[str, float, int],
         position_index: str,
         tokens: Optional[list[DebankDepositToken]] = None,
-        chain: Blockchain,
+        chain: Optional[Blockchain] = None,
         update_at: Optional[Union[int, float]] = None,
     ) -> 'DebankAppDeposit':
         return cls(