fix: update source_id in duplicate item name test to private address, to address SonarQube feedback, and remove stale line

m-d-brown · m-d-brown · commit 2c972a911732 · 2026-04-28T00:07:08.000-07:00
diff --git a/tests/test_omnilogic.py b/tests/test_omnilogic.py
@@ -42,11 +42,11 @@ def test__check_duplicate_item_names_different_host() -> None:
     ]
     warning = _check_duplicate_item_names(
         items,
-        source_id="10.0.0.1:3000",
+        source_id="127.0.0.2:3000",
     )
 
     assert warning is not None
-    assert "OmniLogic 10.0.0.1:3000 contains multiple items with the same name:" in warning
+    assert "OmniLogic 127.0.0.2:3000 contains multiple items with the same name:" in warning
 
 
 def test__check_duplicate_item_names_no_duplicates() -> None:

Original file line number	Diff line number	Diff line change
`@@ -42,11 +42,11 @@ def test__check_duplicate_item_names_different_host() -> None:`
`42`	`42`	`]`
`43`	`43`	`warning = _check_duplicate_item_names(`
`44`	`44`	`items,`
`45`		`- source_id="10.0.0.1:3000",`
	`45`	`+ source_id="127.0.0.2:3000",`
`46`	`46`	`)`
`47`	`47`
`48`	`48`	`assert warning is not None`
`49`		`- assert "OmniLogic 10.0.0.1:3000 contains multiple items with the same name:" in warning`
	`49`	`+ assert "OmniLogic 127.0.0.2:3000 contains multiple items with the same name:" in warning`
`50`	`50`
`51`	`51`
`52`	`52`	`def test__check_duplicate_item_names_no_duplicates() -> None:`