feat: update linter (#1826)

* update lint

* to be reverted: enable linter in this PR

* revert

* fix lint

* fix more lint

* add changelog

* fix lint

* fix lint

* remove comment

* fix comments

Author: thomas-nguy

.github/workflows/lint.yml

@@ -46,13 +46,13 @@ jobs:
 
           BUILD_TAGS=rocksdb,grocksdb_clean_link,objstore
           go build -tags $BUILD_TAGS ./cmd/cronosd
-          golangci-lint run --out-format=github-actions --path-prefix=./ --timeout 30m --build-tags $BUILD_TAGS
+          golangci-lint run --output.text.path stdout --path-prefix=./ --timeout 30m --build-tags $BUILD_TAGS
           cd versiondb
-          golangci-lint run --out-format=github-actions --path-prefix=./versiondb --timeout 30m --build-tags $BUILD_TAGS
+          golangci-lint run --output.text.path stdout --path-prefix=./versiondb --timeout 30m --build-tags $BUILD_TAGS
           cd ../memiavl
-          golangci-lint run --out-format=github-actions --path-prefix=./memiavl --timeout 30m --build-tags objstore
+          golangci-lint run --output.text.path stdout --path-prefix=./memiavl --timeout 30m --build-tags objstore
           cd ../store
-          golangci-lint run --out-format=github-actions --path-prefix=./store --timeout 30m --build-tags objstore
+          golangci-lint run --output.text.path stdout --path-prefix=./store --timeout 30m --build-tags objstore
         # Check only if there are differences in the source code
         if: steps.changed-files.outputs.any_changed == 'true'
 

.golangci.yml

@@ -1,64 +1,143 @@
+version: "2"
 run:
   tests: true
   timeout: 10m
-  sort-results: true
   allow-parallel-runners: true
-  exclude-dir: testutil/testdata_pulsar
   concurrency: 4
-
 linters:
-  disable-all: true
+  default: none
   enable:
+    - copyloopvar
     - dogsled
-    - exportloopref
+    - errcheck
+    - errorlint
     - goconst
     - gocritic
-    - gofumpt
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
     - nakedret
     - nolintlint
+    - revive
     - staticcheck
-    - stylecheck
-    - typecheck
+    - thelper
     - unconvert
     - unused
+    - tagalign
 
+  settings:
+    dogsled:
+      max-blank-identifiers: 3
+    gocritic:
+      disabled-checks:
+        - regexpMust
+        - appendAssign
+        - ifElseChain
+    gosec:
+      excludes:
+        - G101
+        - G107
+        - G404
+      confidence: medium
+    misspell:
+      locale: US
+    nolintlint:
+      allow-unused: false
+      require-explanation: false
+      require-specific: false
+    revive:
+      rules:
+        - name: redefines-builtin-id
+          disabled: true
+        - name: exported
+          severity: error
+          disabled: false
+    staticcheck:
+      checks:
+        - all
+    unused:
+      local-variables-are-used: false
+  exclusions:
+    generated: lax
+    presets:
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - staticcheck
+        text: 'ST1000:'
+      - linters:
+          - revive
+        text: 'or be unexported' # don't report types that have no comments at all. there are way too many of these.
+      - linters:
+          - staticcheck
+        text: 'ST1003:'
+      - linters:
+          - staticcheck
+        text: 'ST1016:'
+      - linters:
+          - staticcheck
+        path: migrations
+        text: 'SA1019:'
+      - linters:
+          - staticcheck
+        text: 'SA1019: codec.NewAminoCodec is deprecated'
+      - linters:
+          - staticcheck
+        text: 'SA1019: legacybech32.MustMarshalPubKey'
+      - linters:
+          - staticcheck
+        text: 'SA1019: legacybech32.MarshalPubKey'
+      - linters:
+          - staticcheck
+        text: 'SA1019: legacybech32.UnmarshalPubKey'
+      - linters:
+          - staticcheck
+        text: 'SA1019: params.SendEnabled is deprecated'
+      - linters:
+          - gosec
+        text: 'G115: integer overflow conversion'
+      - linters:
+          - nolintlint
+        text: leading space
+    paths:
+      - .*\.pb\.go$
+      - .*\.pb\.gw\.go$
+      - .*\.pulsar\.go$
+      - third_party$
+      - builtin$
+      - examples$
+      - ./pystarport/*
+      - testutil/testdata_pulsar
 issues:
-  exclude-rules:
-    - text: "Use of weak random number generator"
-      linters:
-        - gosec
-    - text: "ST1003:"
-      linters:
-        - stylecheck
-    # FIXME: Disabled until golangci-lint updates stylecheck with this fix:
-    # https://github.com/dominikh/go-tools/issues/389
-    - text: "ST1016:"
-      linters:
-        - stylecheck
-    - path: "migrations"
-      text: "SA1019:"
-      linters:
-        - staticcheck
-    - text: "leading space"
-      linters:
-        - nolintlint
-
   max-issues-per-linter: 10000
   max-same-issues: 10000
-
-linters-settings:
-  dogsled:
-    max-blank-identifiers: 3
-  maligned:
-    # print struct with more effective memory layout or not, false by default
-    suggest-new: true
-  nolintlint:
-    allow-unused: false
-    allow-leading-space: true
-    require-explanation: false
-    require-specific: false
+formatters:
+  enable:
+    - gci
+    - gofumpt
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - prefix(cosmossdk.io)
+        - prefix(github.com/cosmos/cosmos-sdk)
+      custom-order: true
+    gofumpt:
+      extra-rules: true
+  exclusions:
+    generated: lax
+    paths:
+      - server/grpc/gogoreflection/fix_registration.go
+      - fix_registration.go
+      - .*\.pb\.go$
+      - .*\.pb\.gw\.go$
+      - .*\.pulsar\.go$
+      - proto/*
+      - third_party$
+      - builtin$
+      - examples$
+      - ./pystarport/*

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 * [#1779](https://github.com/crypto-org-chain/cronos/pull/1779) Upgrade rocksdb to `v9.11.2`.
 * [#1824](https://github.com/crypto-org-chain/cronos/pull/1824) Rework on github actions.
+* [#1826](https://github.com/crypto-org-chain/cronos/pull/1826) Update linter and tidy up code.
 
 *Jun 20, 2025*
 

Makefile

@@ -16,6 +16,8 @@ DOCKER := $(shell which docker)
 
 UNAME_S := $(shell uname -s)
 
+GOLANGCI_VERSION := "2.1.6"
+
 # process build tags
 build_tags = netgo objstore pebbledb
 ifeq ($(NETWORK),mainnet)
@@ -128,12 +130,16 @@ clean:
 ###                                Linting                                  ###
 ###############################################################################
 
+lint-install:
+	@echo "--> Installing golangci-lint $(GOLANGCI_VERSION)"
+	@nix profile install -f ./nix golangci-lint
+
 lint:
 	go mod verify
-	golangci-lint run --out-format=tab
+	golangci-lint run --output.text.path stdout --path-prefix=./
 
 lint-fix:
-	golangci-lint run --fix --out-format=tab --issues-exit-code=0
+	golangci-lint run --fix --output.text.path stdout --issues-exit-code=0
 
 lint-py:
 	flake8 --show-source --count --statistics \