Skip to content

fix: add authorisation address check in the blocklist#1924

Merged
thomas-nguy merged 3 commits into
crypto-org-chain:release/v1.6.xfrom
thomas-nguy:thomas/check-auth-address
Nov 24, 2025
Merged

fix: add authorisation address check in the blocklist#1924
thomas-nguy merged 3 commits into
crypto-org-chain:release/v1.6.xfrom
thomas-nguy:thomas/check-auth-address

Conversation

@thomas-nguy

Copy link
Copy Markdown
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy
thomas-nguy requested a review from a team as a code owner November 24, 2025 08:41
@thomas-nguy
thomas-nguy requested review from JayT106 and randy-cro and removed request for a team November 24, 2025 08:41
@coderabbitai

coderabbitai Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

This comment has been minimized.

@calvinaco calvinaco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread app/block_address.go Outdated

@JayT106 JayT106 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-nguy
thomas-nguy enabled auto-merge (squash) November 24, 2025 10:32
@thomas-nguy
thomas-nguy merged commit a0fd1f3 into crypto-org-chain:release/v1.6.x Nov 24, 2025
53 checks passed
thomas-nguy added a commit to thomas-nguy/cronos that referenced this pull request Dec 2, 2025
…in#1924)

* add missing authorisation address

* add changelog

* remove extra line
github-merge-queue Bot pushed a commit that referenced this pull request Dec 2, 2025
* feat: check authorization list in e2ee (#1903)

* check authorisation list in e2ee

* fix golang-ci

* fix upgrade

* add integration tests

* feat: check destination address in the blocklist (#1922)

* add check destination address

* add changelog

* add nil check

* fix: add authorisation address check in the blocklist (#1924)

* add missing authorisation address

* add changelog

* remove extra line

* fix changelog

* python lint
randy-cro added a commit that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants