Address review comments: remove Premium section header, clarify FlavorConfig KDoc

Author: tobihagemann

presentation/src/main/java/org/cryptomator/presentation/ui/fragment/SettingsFragment.kt

@@ -186,7 +186,6 @@ class SettingsFragment : PreferenceFragmentCompatLayout() {
 	private fun setupLicense() {
 		val licenseCategory = findPreference(LICENSE_ITEM_KEY) as PreferenceCategory?
 		val licensePref = findPreference(SharedPreferencesHandler.MAIL) as Preference?
-		licenseCategory?.title = getString(R.string.screen_settings_license)
 		licensePref?.isEnabled = true
 		when {
 			FlavorConfig.isPremiumFlavor -> {

presentation/src/main/res/values/strings.xml

@@ -706,7 +706,6 @@
 	<string name="screen_settings_clear_lru_cache_size">Clear Cache</string>
 	<string name="screen_settings_lru_cache_changed__restart_toast">Changes will be applied on next app restart</string>
 
-	<string name="screen_settings_license">Premium</string>
 	<string name="screen_settings_license_title_unlock">Unlock Full Version</string>
 	<string name="screen_settings_license_title_unlocked">Full Version</string>
 	<string name="screen_settings_license_mail">%1$s</string>

presentation/src/main/res/xml/preferences.xml

@@ -2,9 +2,7 @@
 <androidx.preference.PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
 	android:id="@+id/activity_root_view">
 
-	<PreferenceCategory
-		android:key="license"
-		android:title="@string/screen_settings_license">
+	<PreferenceCategory android:key="license">
 
 		<androidx.preference.PreferenceScreen
 			android:enabled="false"

util/src/main/java/org/cryptomator/util/FlavorConfig.kt

@@ -2,7 +2,7 @@ package org.cryptomator.util
 
 object FlavorConfig {
 
-	/** Premium flavors: Play Store and Accrescent editions. License enforcement is bypassed. */
+	/** Premium flavors (Play Store and Accrescent editions) ship with full access, so license enforcement is bypassed. */
 	val isPremiumFlavor: Boolean
 		get() = BuildConfig.FLAVOR == "playstore" || BuildConfig.FLAVOR == "accrescent"